buck tracks files it shouldn't in a version control directory (sapling) about buck2

[thoughtpolice]

Oh, there is a setting for this; in the root .buckconfig:

[project]
ignore=.git,.sl,.jj

Took me a minute to find that; should have looked at the Buck 1 site (it's occasionally come in handy still.) Closing this as it can be solved easily.

[ndmitchell]

If you are using the watchman file watcher (not the default in open source) you are encouraged to add it to the watchman ignore, as it will generate less events. In 87ab0b6 I made it so that we implicitly ignore buck-out. I wonder if .git etc should be defaults too?

[thoughtpolice]

Yeah, seeing that commit was the impetus for investigating the .sl directory and this whole issue. There are some pretty reasonable and unambiguous things to ignore: .git, .sl, .jj (for jujutsu) are three obvious ones I'm using. Something like node_modules would also be good.

There's also whether or not something should be ignored recursively by default. node_modules would probably qualify, but unfortunately Cargo's target subdirectory is a bit more of an open question since it's so ambiguous.

Can I ask how watchman integration is supposed to work? Do I need to launch it myself on the repo root, first? I actually got the Ubuntu 22.04 binary working yesterday, but hadn't yet dug into the source to figure out the integration.

[thoughtpolice]

Found that out too: put the following in .buckconfig

[buck2]
file_watcher=watchman

then start a watchman daemon somewhere above the source dir, and set WATCHMAN_SOCK to the socket file appropriately. Seems to be working and ignoring cargo files now!

[ndmitchell]

I think having an initialisation command generate a ignore makes a lot of sense, but I worry about defaulting to things like node_modules without explicit user direction, as otherwise you can potentially accidentally ignore someones code, and then it gets real confusing.

The idea for watchman is if the binary exists it should just work, and it did for me on Windows. But from your remarks elsewhere, sounds like you probably know more than I do by now :)