Coder Social home page Coder Social logo

jio's Issues

Slice of errors for validation

It might be good have multiple errors for fields. Right now validation return error message only about one field, not all failed.

Keys() needs to set skip to false after iteration.

Using the README example with a small change (add optional "foo") will result in the Without() being ignored. This is because AnySchema.Optional() calls ctx.Skip():

package main

import (
    "fmt"
    "log"

    "github.com/faceair/jio"
)

func jioNotAllowed(ctx *jio.Context) {
    ctx.Abort(fmt.Errorf("Attribute `%s` not allowed in this context.", ctx.FieldPath()))
    return
}

func main() {
    data := []byte(`{                                                                                                                                                                                                                                     
        "debug": "on",                                                                                                                                                                                                                                    
        "window": {                                                                                                                                                                                                                                       
            "title": "Sample Widget",                                                                                                                                                                                                                     
            "size": [500, 500]                                                                                                                                                                                                                            
        }                                                                                                                                                                                                                                                 
    }`)
    _, err := jio.ValidateJSON(&data, jio.Object().Keys(jio.K{
        "debug": jio.Bool().Truthy("on").Required(),
        "window": jio.Object().Keys(jio.K{
            "title": jio.String().Min(3).Max(18),
            "size":  jio.Array().Items(jio.Number().Integer()).Length(2).Required(),
            "foo":   jio.Any(),
        }).Without("name", "title").Required(),
    }))
    if err != nil {
        panic(err)
    }
    log.Printf("%s", data)
}

This results in no errors, even though we should expect "panic: field window contains title"

If you remove the "foo" line, it works correctly:

panic: field `window` contains title

The problem is in the ObjectSchema.Keys() - it needs to set ctx.skip to false after the for loop.

`ObjectSchema` keys are unconditionally added to the JSON object validated 

package main

import (
	"bytes"
	"log"

	"github.com/faceair/jio"
)

func main() {
	orig := []byte(`{}`)
	data := []byte(`{}`)
	schema := jio.Object().Keys(jio.K{
		"foo": jio.String(),
	})

	if _, err := jio.ValidateJSON(&data, schema); err != nil {
		log.Fatal(err)
	}

	if !bytes.Equal(orig, data) {
		log.Printf("Want %s, got %s.", orig, data)
	}
}

prints

Want {}, got {"foo":null}.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.