fabric-design / styleguide Goto Github PK

The Feedback page in the style guide, section "Feedback forms", shows the same image twice, once for "Contextual feedback" and once for "Notifications".

It is actually a different file name (feedback2.png vs. feedback3.png), but the same content for both.

Currently, somehow the Aurelia Router is returning empty Params and throws an Error when the App is called via

https://fabric-design.github.io/styleguide/

We should create a README also for our styleguide project. Maybe it doesn't has to be as long as the components README but I think the following points should be written down:

• Motivation (Why?)
• Technical Concepts (A short explanation how the styleguide works, a diagram showing all dependencies and how styleguide works.)
• Getting started (How to test changes locally ?, how to contribute)
• Contributing
• License

Currently the deployment does not work when the triggering branch is a master branch (e.g. scss#master, components#master, ...)
This happens because the environment variable TARGET is empty then and the code reads "" as parameter value.

This might be an intentional quirk or a bug, but it is confusing.

Wrong behavior

At several places, when by grammar an apostrophe is needed, instead a "female sex" symbol (or at least something which looks quite similar) is shown.

Both Opera and Chromium show it like this (e.g. in the feedback page):

Some analysis:

The source code looks like this:

Used when system feedback breaks user activity and using a system can’t be continued without getting an info or making a decision.

(The character in the source is U+2019, RIGHT SINGLE QUOTATION MARK, which is the correct character for an apostrophe, encoded en correct UTF-8 as three bytes.)

The output (at ) looks like this (copied from the browser):

Used when system feedback breaks user activity and using a system can�t be continued without getting an info or making a decision.

(Looks still the same in the editor, and like a unicode replacement character � in the preview. Github might be additionally messing things up.)

In https://fabric-design.github.io/styleguide/scripts/app-bundle.js (which contains this text) it is a single 0x19 byte (U+0019), i.e. an END OF MEDIUM control character. (The file is delivered as UTF-8, so it could have the correct character.)

It looks like somewhere in the transformation from Markdown to HTML the U+2019 is transformed to U+0019.