fabioarnold / minipixel Goto Github PK

View Code? Open in Web Editor NEW

163.0 9.0 9.0 11.79 MB

A tiny pixel art editor

License: MIT License

Zig 66.65% C 33.31% Objective-C 0.04%

pixel-art zig pixel-editor sprites ziglang

minipixel's Introduction

👋 Hi, I’m Fabio
👀 I’m interested in Zig, graphics programming, games, and pixel art
📫 You can reach me on Twitter @captainhorst or on Discord captainhorst#9617

minipixel's People

Contributors

Stargazers

Watchers

Forkers

corvusetiam foxnne iacore icodein shadeops konosubakonoakua silly-coders marciopocebon

minipixel's Issues

Transformation widget

When having a selection, display handles to allow arbitrary scaling.

Only nearest integer scaling
Always keep the source image while the selection is active
Preview handled in shader

Implement a paletted (8-bit) mode

Implement mode switching between 24 bit true color and indexed mode.

Refactor `ErrorMessageWidget` to be a generic MessageBox

Support different kinds of brushes

When drawing larger pieces it's kind of tedious to draw with a 1x1 brush.

Request origin: https://itch.io/post/5393741

Possible inpiration:

Selection Texture mangled with IndexedBitmap

Howdy!

I was playing with MiniPixel and noticed whenever I select part of the image while in Index mode, the selection texture gets mangled if the selection width is an odd number.

Here is an example gif that alternates between selections with an odd numbered width and an even numbered width.

I traced through the code a bit to try to track this down but everything seems to be working fine until the IndexBitmap is passed to nanovg. For example,

MiniPixel/src/Document.zig

Line 1305 in cb255f1

self.selection_texture = selection.bitmap.createTexture(vg);

selection.indexed_bitmap.indices had the values that I would expect.

This behaviour shows up in Linux and in Windows. Tested on v0.2.1 and the current master, cb255f1.

I'm happy to continue to debug, but just wanted to flag the issue.

Thanks.

Desktop environment freezes in Linux xfce when opening save file dialog window

When I click the save button, the system file dialog opens, but then it is frozen: I cannot click on the button to save or cancel, and all my desktop UI becomes unresponsive to mouse action. I can still do ALT+TAB and the keyboard works, so killing the process via terminal can unfreeze the desktop.

I'm on Linux with xfce desktop.

Other than this so far everything works nicely, great work!

Indicate unsaved changes in title bar

Mark windows for deletion

Don't directly delete windows within a UI event after calling window.close(). Code running during the event handling might try to access the window handle as observed here: e7cd1d9
Instead mark the window for deletion and delete it when event handling is done and not from within an application call stack.

Make undo/redo operations cheaper

In debug builds there's a noticable hang when operations are performed.

Implement loading and saving of color palettes

Write a manual

Good example: https://ogmo-editor-3.github.io/docs/#/manual/introduction.md#manual/introduction.md

Choose a background color from the palette with right click

Issues Minimizing Window on Linux

Howdy,

I noticed some issues when trying to minimize MiniPixel on Linux. (MiniPixel is so awesome I hadn't tried to minimize it before now. 😄 )

Here is a .gif of what happens when the window's minimize button is clicked.

The window loses focus but the immediately seems to un-minimize itself. Additionally if I go to another desktop, I can see it show up in the task bar which generally only happens if an application is trying to get attention.

I have zero SDL experience, but my guess is that the SdlWindow.draw() call is sees that the window is hidden and tells the window manager to show it:

MiniPixel/src/main.zig

Lines 261 to 263 in f5f0195

    
           if (c.SDL_GetWindowFlags(self.handle) & c.SDL_WINDOW_HIDDEN != 0) { 
        
               c.SDL_ShowWindow(self.handle); 
        
           }