f9webltd / laravel-meta Goto Github PK

Double quotes cause issues such as:

<meta name="description" content="We sell 20" industrial nails">

At the very least htmlentities should be ran on such tags so they become:

<meta name="description" content="We sell 20&quot; industrial nails">

Without accounting for the meta description can be truncated 🦈

Instead of hardcoding ' - ' as a title seperator it would be nice to have that configurable.

Support PHP ^8.0

Scruitinzer fails after changes to composer.json - see https://scrutinizer-ci.com/g/f9webltd/laravel-meta/inspections/0bb078c0-b82e-4a1b-8894-eb678c1fec13

"PHP Analyzer: Determining Dependencies - Analyzing composer.json/composer.lock files to determine dependencies of the root package"

All tests pass but this fails after the commit 2d52ea7#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

Could do with some help?

i.e. user-reports should result in User Reports as oppossed to User-reports

Migrate away from Scrutinizer and use GitHub actions to run tests on multiple versions of PHP and Laravel.

Hello I have default value

'defaults' => [
        'charset' => 'utf-8',
        'robots' => 'index, follow',
...

When I use meta()->noIndex()
It doesn't rewrite default value. When I remove default value, it works.
What could it be?

Hi,

I'm trying to overwrite default meta but it doesn't work.

f9web-laravel-meta.php

  'defaults' => [
      'property:og:data' => 'ZZZ',
  ];

MyController

  meta()->set('property:og:data', 'YYY');
  // OR
  meta()->forget('property:og:data')
       ->forget('og:data')
       ->set('property:og:data', 'YYY');

Header

  <meta property="og:data" content="ZZZ">

is there a way to override it?

• Add hero image
• Simplify read me passage describing meta title guessing

See

The path is not always present, need to handle thisa to avoid an Undefined index: path error. Appears to only apply for weird incoming requests to the application.

It appears Laravel has its own Conditionable trait, see https://github.com/laravel/framework/blob/8.x/src/Illuminate/Support/Traits/Conditionable.php

It would be nice to use this as opposed to the internal implementation at https://github.com/f9webltd/laravel-meta/blob/master/src/Meta.php#L124-L134

Very open to a PR on this.