eyecuelab / kit Goto Github PK

This issue has been opened automaticaly because we think you are using satori/uuid in your code. Unfortunately, satori/uuid has a critical defect where it doesn't generate random UUIDV4s satori/go.uuid#73 and should be replaced as the maintainer has been unresponsive for 5 months with the bug still open. Alternative packages you should consider: https://github.com/google/uuid https://github.com/pborman/uuid

In web/middleware/template.go, we have the following function:

func TemplateWithConfig(config TemplateConfig) echo.MiddlewareFunc {
	if config.Skipper == nil {
		config.Skipper = DefaultTemplateConfig.Skipper
	}

	return func(next echo.HandlerFunc) echo.HandlerFunc {
		return func(c echo.Context) (err error) {
			if config.Skipper(c) { // this branch does nothing
				return next(c)
			}

			return next(c)
		}
	}
}

Specifically:

{
    if config.Skipper(c){
        return next(c)
    }
    return next(c)
}

seems wrong. Why do we test for config.Skipper if it doesn't matter? Does it have side effects? Couldn't we just replace the whole branch withreturn next(c)?

We have a GOTO in the following function in web/error_handler.go

goto ERROR is identical to

logErr(err)
return

here. Is this a relic of a former system, or for performance reasons?

func ErrorHandler(err error, c echo.Context) {
	if c.Response().Committed {
		return
	}

	status, apiError := toApiError(err)

	if c.Request().Method == "HEAD" {
		if err := c.NoContent(status); err != nil {
			goto ERROR
		}
		return
	}

	if err := renderApiErrors(c, apiError); err != nil {
		//are we supposed to log this error twice?
		logErr(err)
		goto ERROR
	}

	if status < 500 {
		return
	}
ERROR:
	logErr(err)
}

In cfg/cfg.go, we have the function BeenSet.

BeenSet generally shows whether or not the value of a type is the NOT zero value of a type (with the exception of bool).

However, the default case here shows whether the value of a type IS the zero value of interface{}.

This seems wrong!

func BeenSet(v interface{}) bool {
	switch v.(type) {
	case int, int8, int16, int32, int64, uint, uint8, uint16, uint32, uint64, float32, float64:
		return v.(int) != 0
	case string, []rune, []byte:
		return v.(string) != ""
	case []int, []int8, []int16, []int64, []uint, []uint16, []uint64, []float32, []float64:
		return v.([]interface{}) != nil
	case bool:
		return true // no way to tell
	default:
		var other interface{} 
		return v.(interface{}) == other
                //should this be !=??
       
	}
}