[FEAT] Allow integration tests using EE version about github-actions-m2

[damienwebdev]

This was originally addressed by #48 but is now reverted by 6f754f3 and 4885780

I don't really understand why there are 3 different variables for $MAGENTO_PROJECT_NAME ($PROJECT_NAME, $INPUT_PROJECT_NAME)

INPUT_PROJECT_NAME="magento/project-enterprise-edition" && MAGENTO_PROJECT_NAME=""
test -z "${MAGENTO_PROJECT_NAME}" || MAGENTO_PROJECT_NAME=$INPUT_PROJECT_NAME
test -z "$MAGENTO_PROJECT_NAME" && MAGENTO_PROJECT_NAME="magento/project-community-edition"
echo $MAGENTO_PROJECT_NAME

[jissereitsma]

Yes and no. By using env it works for me. By using with it does not work for me. Which YAML are you using?

[damienwebdev]

  steps:
      - uses: actions/checkout@v2
      - name: M2 Integration Tests with Magento 2 (Php7.4)
        uses: extdn/github-actions-m2/magento-integration-tests/7.4
        with:
          module_name: MyPackage
          composer_name: namespace/package
          ce_version: '2.4.3'
          project_name: magento/project-enterprise-edition
        env:
          REPOSITORY_URL: https://repo.magento.com/
          COMPOSER_AUTH: ${{ secrets.COMPOSER_AUTH }}

[jissereitsma]

Ok, in my own trials there is also an env with name PROJECT_NAME set. But the variable structure is indeed bad, to say the least. Let me get into a fix.

[jissereitsma]

To comment upon the confusion: The project was once kickstarted by Kristof who created a MAGENTO_PROJECT_NAME variable in the entrypoint script, but a PROJECT_NAME variable in the action input. I then added a INPUT_PROJECT_NAME variable, so that the input could be either given through with or through env in your own YAML. This is where the current bug was introduced, where both with and env are suddenly required (your mentions of my commits), which is obviously wrong.

However, I would like to then refactor all, so that there is only a single variable PROJECT_NAME which could be either set using with or using env:

        env:
            PROJECT_NAME: "magento/project-enterprise-edition"

        with:
          project_name: magento/project-enterprise-edition

This only means that the environment variable PROJECT_NAME and the input variable INPUT_PROJECT_NAME would need to be supported in the entrypoint script.

[jissereitsma]

Like this: 6ad270b Let me know if this fixes things for you.

[piotrkwiecinski]

I can confirm that using PROJECT_NAME works with EE version

[jissereitsma]

I'm going to close this issue, because I've gotten various reports now that this was solved correctly (even though I suspect @damienwebdev is no longer using this specific solution ;))

[damienwebdev]

@jissereitsma yes, confirming this works, sorry for never closing the issue.