Coder Social home page Coder Social logo

Comments (6)

jissereitsma avatar jissereitsma commented on July 20, 2024

/cc @damienwebdev

from github-actions-m2.

damienwebdev avatar damienwebdev commented on July 20, 2024

@jissereitsma indeed - https://github.com/graycoreio/github-actions-magento2/blob/main/.github/workflows/integration.yaml#L114

This came from @convenient magento/magento2#35596

from github-actions-m2.

jissereitsma avatar jissereitsma commented on July 20, 2024

Note that 2.8 will still include this change :)

My own Magento issue is a duplicate. I'll close it right away.

from github-actions-m2.

jissereitsma avatar jissereitsma commented on July 20, 2024

Added for now like this: 1cc6ce6

from github-actions-m2.

convenient avatar convenient commented on July 20, 2024

@jissereitsma Yeah agreed that 2.8 monolog will still include this change my thoughts were

  • Do not use 2.7.0 as its known breaking
  • Wait for feedback on Seldaek/monolog#1684 and magento/magento2#35596 to see what the "correct" thing to do is
    • Hope that either of those projects will fix forward and bring compatibility back in again

This was to hopefully prevent against weird scenarios in future where I've locked to 2.6.0 but need higher, honestly as well to keep it painful a little bit. Don't want to forget this is an issue that needs handled :p

from github-actions-m2.

jissereitsma avatar jissereitsma commented on July 20, 2024

@convenient I definitely like the approach of asking for feedback on the comment that Jordi (Seldaek) made, but I'm actually not sure if anyone will pick up on this. It might very well be that the person know built this in the past, moved on already.

A handler is a better idea indeed. I already refactored a couple of things in my dev environment to allow for this. But I'm also just wondering who is using this logging ability. Plus I read that in PHPUnit 10 the logger listening feature is actually going to be removed :o

from github-actions-m2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.