Comments (6)
I got tired of fighting this. https://github.com/graycoreio/github-actions-magento2 has a very clear and concise way to accomplish this now.
from github-actions-m2.
@sprankhub indeed this is not yet ideal. The issue I encountered when trying to pass in the php version is that we are also not able to use this input parameter value in the action here. So then we end up with needing to do this at runtime which adds execution time.
I was thinking to go further down the route of having even more images that have the Magento install already done (and maybe keep the current way as an option as it does catch 1 type of issue with the sequencing of modules and db installs).
But maybe we end up having various different options so that every one can choose what works best for them.
from github-actions-m2.
I think this is a good way to solve this: https://github.com/MAD-I-T/magento-actions/blob/master/entrypoint.sh#L6
Ideally this could be combined with a base image to provide a php option for all actions in this repo.
from github-actions-m2.
@damienwebdev I'm not sure which fight you got tired off. But indeed if it is the structure of the current ExtDN actions that would need to be refactored into something else, then I feel I need to point out that the ExtDN actions are open for contributions, definitely by ExtDN members. The work you have put into a personal version instead is in the spirit of open source and I find nothing wrong with that. There can be multiple open source projects with the same goal - let users decide which is better. But by posting here, I got the feeling that you would have liked that your fix / change was part of the ExtDN repo instead, but never suggested here - a fight was over before it got started.
from github-actions-m2.
I'm really looking to leverage my actions as a trial for an API of actions that could replace ExtDN Actions (a v2 of sorts).
To be clear, I wholly intend to donate my actions repo back to this repo.
My concern and the reason for not contributing directly is that my changes are fairly breaking. I changed APIs that felt uncomfortable to me and I took a different approach by publishing a mix of workflows and actions.
Consider the docker images that you use here as an example, that layer alone chiefly prevented the usage of matrixes and changing it around would break the API.
In addition, I didn't see a clear way to layer in my idea around "supported versions".
Ultimately, the diff count to get from here to there seemed gratuitous and time-inefficient.
"Fight" was likely a strong choice of words, which I wrote out of frustration (which I'm sorry about), but I was chiefly fighting the API, not the people of this project.
from github-actions-m2.
To be clear, I wholly intend to donate my actions repo back to this repo.
Nice. Nuff said :)
My concern and the reason for not contributing directly is that my changes are fairly breaking.
This is actually also my struggle into trying to make improvements. I'm not sure who is using what in what kind of way. A v2 sounds more like a plan!
from github-actions-m2.
Related Issues (20)
- [Question] Run Magento Coding Standard check on changed files HOT 2
- ERROR: Referenced sniff "PHPCompatibility.FunctionUse.RemovedFunctions" does not exist HOT 3
- Error: file_put_contents(/m2/app/etc/vendor_path.php): Failed to open stream: No such file or directory HOT 9
- [BUG] Magento 2 Tests Integration tests fail unless the key USE_OVERRIDE_CONFIG is set to enabled in `phpunit.xml` HOT 3
- Feat: Support PHP 8.1 Actions HOT 6
- Newer PHPUnit versions don't allow for non-existing directories in testsuites HOT 5
- Add PHP 8.1 support for PHPStan HOT 3
- Missing Env Variables HOT 5
- [BUG] Integration tests fails as a result of recent `composer` breaking changes HOT 2
- Monolog 2.7 causes breaking changes that make Integration Tests fail HOT 6
- Unable to parse fixtures error on Magento 2.4.5 HOT 3
- How can I run M2 PHPStan on specific branch not on composer package
- Add support for new Variables
- Github.com contains invalid characters caused by old composer docker images
- PHPStan. Add support to change repository url
- Error Running Copy/Paste Detector
- PHPStan "module_source" variable seemingly not used HOT 2
- PHP 8.2 Support HOT 1
- Integration tests failing for Magento 2.3 HOT 4
- Update extdn/magento-coding-standard-action Docker Images Regularly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-actions-m2.