Comments (9)
Let's keep it open for the moment. I'd like to take a look at pre-seeding the Composer cache for the mirror repo.
from github-actions-m2.
Am still also considering pre-building images to effectively jump straight to here
https://github.com/extdn/github-actions-m2/blob/master/magento-unit-tests/entrypoint.sh#L31
(could be done for integration tests too, but should stop before the set up step)
from github-actions-m2.
I just found --repository=https://repo-magento-mirror.fooman.co.nz/
is used for the integration test build, but not for the unit test build.
Is there a reason to stick with the "official" repo for the unit tests?
from github-actions-m2.
By the way, THANK YOU @fooman for setting up the mirror!
from github-actions-m2.
I think this is just work in progress. The first step into improving things was to add secrets, so that the secrets could be used in different actions - this is what I'm using already, but indeed, the secrets will not work with Pull Requests :( For that matter, there is no way to share an environment variable ("secret") with others than the contributors of the project.
However, the thing that you bump into is more a flaw in the documentation, than the actual workflow files. In the docs, it is mentioned to use the following snippet:
jobs:
env:
MAGENTO_MARKETPLACE_USERNAME: ${{ secrets.MAGENTO_MARKETPLACE_USERNAME }}
MAGENTO_MARKETPLACE_PASSWORD: ${{ secrets.MAGENTO_MARKETPLACE_PASSWORD }}
But it is quite common that people fill in the details differently. The dependency in the workflow files is with the environment variable. The way to fill in that environment variable - for instance, using secrets or hard-coded - is up to you. (Obviously, hard-coded is not pretty.)
jobs:
env:
MAGENTO_MARKETPLACE_USERNAME: foo
MAGENTO_MARKETPLACE_PASSWORD: bar
But you already changed the topic: Why not use the mirror? Good point - I see no reason not to. I'm going to fix that right away. Ideally, with a switch REPOSITORY_URL
which defaults to https://repo-magento-mirror.fooman.co.nz/
.
from github-actions-m2.
Done.
from github-actions-m2.
Awesome, thanks @jissereitsma. This should make it easier to use for open source modules.
from github-actions-m2.
Cam this issue be closed?
from github-actions-m2.
@fooman As of yet, all is working fine with this change. Can we close this issue?
from github-actions-m2.
Related Issues (20)
- Cannot use PHP 7.4 action for coding standards HOT 5
- Add problem matcher support for PHPMD HOT 3
- Magento-phpstan Action: Why do we need a composer package for it? Composer 2.0 is not supported! HOT 4
- [BUG] Magento 2 Tests Integration tests fail unless the key USE_OVERRIDE_CONFIG is set to enabled in `phpunit.xml` HOT 3
- Feat: Support PHP 8.1 Actions HOT 6
- Newer PHPUnit versions don't allow for non-existing directories in testsuites HOT 5
- Add PHP 8.1 support for PHPStan HOT 3
- Missing Env Variables HOT 5
- [BUG] Integration tests fails as a result of recent `composer` breaking changes HOT 2
- Monolog 2.7 causes breaking changes that make Integration Tests fail HOT 6
- Unable to parse fixtures error on Magento 2.4.5 HOT 3
- How can I run M2 PHPStan on specific branch not on composer package
- Add support for new Variables
- Github.com contains invalid characters caused by old composer docker images
- PHPStan. Add support to change repository url
- Error Running Copy/Paste Detector
- PHPStan "module_source" variable seemingly not used HOT 2
- PHP 8.2 Support HOT 1
- Integration tests failing for Magento 2.3 HOT 4
- Update extdn/magento-coding-standard-action Docker Images Regularly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-actions-m2.