Comments (3)
Hey @Vinai thanks for giving these actions a try and your feedback.
Just to confirm that I understand this issue correctly. You are currently running the integration test action from this repo and then you want to use a separate github action after it that should work with the M2 set up by this action?
Happy to go ahead with the suggested folder changes. @jissereitsma any concerns?
from github-actions-m2.
@fooman You are correct.
To make it more concrete, in my case, I wanted to run rector on the module and then run the tests again with a different PHP version.
Executing rector required running static:content:deploy, which in turn requires a complete install.
This would be possible by adding another step to the workflow that reuses the existing installation.
My only concern is that making these changes maybe could break existing workflows?
Maybe the build dir should only be inside the workspace if a $BUILD_DIR environment input is set, and if it isn't set, the default /tmp/m2 is used and the workspace is the module source?
from github-actions-m2.
My only concern is that making these changes maybe could break existing workflows?
It's still early days for these actions. A quick search over all of github did not yield any repos that would rely on this internal implementation detail. (most of these repos are ExtDN related). Technically there could be private ones that I do not see but again I am somewhat confident that relying on /tmp/m2 vs the MAGE_ROOT that we already have is highly unlikely.
from github-actions-m2.
Related Issues (20)
- [Question] Run Magento Coding Standard check on changed files HOT 2
- ERROR: Referenced sniff "PHPCompatibility.FunctionUse.RemovedFunctions" does not exist HOT 3
- Error: file_put_contents(/m2/app/etc/vendor_path.php): Failed to open stream: No such file or directory HOT 9
- [BUG] Magento 2 Tests Integration tests fail unless the key USE_OVERRIDE_CONFIG is set to enabled in `phpunit.xml` HOT 3
- Feat: Support PHP 8.1 Actions HOT 6
- Newer PHPUnit versions don't allow for non-existing directories in testsuites HOT 5
- Add PHP 8.1 support for PHPStan HOT 3
- Missing Env Variables HOT 5
- [BUG] Integration tests fails as a result of recent `composer` breaking changes HOT 2
- Monolog 2.7 causes breaking changes that make Integration Tests fail HOT 6
- Unable to parse fixtures error on Magento 2.4.5 HOT 3
- How can I run M2 PHPStan on specific branch not on composer package
- Add support for new Variables
- Github.com contains invalid characters caused by old composer docker images
- PHPStan. Add support to change repository url
- Error Running Copy/Paste Detector
- PHPStan "module_source" variable seemingly not used HOT 2
- PHP 8.2 Support HOT 1
- Integration tests failing for Magento 2.3 HOT 4
- Update extdn/magento-coding-standard-action Docker Images Regularly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-actions-m2.