expworlds / godot-cel-shader Goto Github PK

First off I would just like to say your shader is great and works very well. Also, thanks for fixing the textures bug so fast.

I think two improvements that would make this even better are support for normal maps and multiple lights. Multiple lights seems like it is tricky though.

On to what this issue is about normal maps, it would be great to have support for normal maps. I have the charactor setup and they look great but my charactor does have a normal map for details. If I could utilize that as well it would be even better.

Thanks :)

First of all, thanks for this awesome shader!
There is one thing I noticed dough while using it, the shader only receives one light source.

You may want to change:
https://github.com/EXPWorlds/Godot-Cel-Shader/blob/master/Shaders/cel.shader#L83
to:

DIFFUSE_LIGHT += diffuse;

Source: https://godotengine.org/qa/48323/my-custom-light-shader-received-only-a-single-light

For testing I applied the shader to this character from Genshin Impact. This meant that you could see the back of the mesh in some places. After adding the outline shader a few spots disappeared but a few didn't.

I used the Godot version 4 so maybe I made a mistake by modifying the shader for the new version even thought I don't think this is the case because I didn't changed much.

I am not good at shader programming so is there anyone, who can help me with this problem?
Down here is a image with the faulty spots marked in red:

When adding a texture it appears faded. I attempted to play around with the settings which unfortunately didn't help.

Spatial Material:

Cel Shader: