event_base_free problems about pecl-event-libevent

[ichiriac]

Could you fork my repository, add some phpt unit tests files and make a pull request. Future migrations will be easier

[ichiriac]

Hi,

the bug comes from an allocation problem and the garbage collector, at the second pass, it destroys the event buffer BEFORE attaching it to the $ev.

After some investigations, it problably comes from a bad GC counter on the $base variable and an edge bug on php7.

I have no more time to work on this right now (I do this on my spare time), I'll come back on it maybe in a few weeks ...

[Joungkyun]

solved this problem include case 1 and case 2. see also attached patch file.
And, confirm no memory leak with valgrind.

also, fixed compile error too. follow code has compile error.

-php_sock = (php_socket *)zend_fetch_resource_ex(fd, NULL, php_sockets_le_socket());
+php_sock = (php_socket *)zend_fetch_resource2_ex(fd, NULL, php_sockets_le_socket());

event_base_free__problems_no.3.diff.txt

P.S.
I have not yet accustomed github system. So instead of push, attach patch file. Thx.
The patch file has unix format(\n). On windows, use wordpad instead of notepad.

[ichiriac]

@Joungkyun thanks for the patch, it works, i've released the code and tests according but seems to have some leaks :

https://travis-ci.org/expressif/pecl-event-libevent/jobs/101288331

To work with github click on "fork" button on the top of this page, a fork project will be created on your own profile.

Checkout your fork, make changes commit & push, and when you are ready, create a pull request from the pull requests tab (on your fork project).

Thanks again for your help,
Best Regards,
Ioan

[Joungkyun]

@ichiriac For libevent001 and libevent002, I think that PHP 7.1 environment seems to be the problem. Plez check again on PHP 7.0 environment.

And libevent003 seems there is a problem in event_base_free.

[ichiriac]

I'm actually using the master branch of PHP to run tests - it's in principle the 'stable' branch of latests release ... I've put an comment dirrectly on your pull request about the memory leaks, you can take a look at the travis logs.

By the way, thanks a lot helping me to solve this problem !

[Joungkyun]

Is really master branch 'stable' branch of latests relelase? The master branch is PHP 7.1 stream and I know that PHP 7.1 stream is not stable. is the lastest stable stream PHP-7.0 branch?