_php_bufferevent_readcb segfult about pecl-event-libevent

[ichiriac]

Hi,

In my tests I was not using the optional argument ($id in the example).

The reason of the fail is explained on the phpng doc :

The main difference is that now we handle scalar and complex types differently. PHP doesn't allocate scalar values in heap but do it directly on VM stack, inside HashTables and object. They are not subjects for reference counting and garbage collection anymore. Scalar values don't have reference counter and don't support Z_ADDREF_(), Z_DELREF_(), Z_REFCOUNT_() and Z_SET_REFCOUNT_() macros anymore. In most cases you should check if zval supports these macros before calling them. Otherwise you'll get an assert() or crash.

- Z_ADDREF_P(zv)
+ if (Z_REFCOUNTED_P(zv)) {Z_ADDREF_P(zv);}
# or equivalently
+ Z_TRY_ADDREF_P(zv);

The reason of the crash is that the argument is a scalar (primitive) integer, and z_addref_p MUST not be used on scalars.

I will publish a patch and send a pull request on this ...