Comments (2)
Thanks a lot, this was an oversight when refactoring some of the code and developing on Windows.
I've replaced usages of char
and unsigned char
with std::int8_t
and std::uint8_t
as this is more expressive anyways: 819dda0
Plus I've added GitHub Actions to see breaking changes for Linux or macOS: 736f33f
from bnkextr.
diff --git a/bnkextr.cpp b/bnkextr.cpp
index 1147b9e..f580979 100644
--- a/bnkextr.cpp
+++ b/bnkextr.cpp
@@ -133,7 +133,7 @@ struct EventActionObject
int Swap32(const uint32_t dword)
{
#ifdef __GNUC__
- return __builtin_bswap32(dw);
+ return __builtin_bswap32(dword);
#elif _MSC_VER
return _byteswap_ulong(dword);
#endif
@@ -259,7 +259,7 @@ int main(int argument_count, char* arguments[])
if (bank_header.version >= 134)
{
- auto count = unsigned char{ 0 };
+ unsigned char count = 0;
ReadContent(bnk_file, count);
event.action_count = static_cast<std::size_t>(count);
}
from bnkextr.
Related Issues (12)
- I need help! HOT 4
- License? HOT 2
- Typo in EventActionType HOT 2
- Kaitai Struct Specification Incompletedness HOT 6
- I am not able to compile it HOT 3
- is there any way to repack it for replacing the sound resources? HOT 2
- bnkextr not actually extracting HOT 3
- Is there an exe to do the copy paste trick on windows ? HOT 6
- File location Issues HOT 3
- Can not open .exe HOT 4
- Baldur'sGate 3 sounds banks extract not working HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bnkextr.