ex-aws / ex_aws_rds Goto Github PK

There are some nice new functions in the two open PRs – any chance that those could be merged sometime soonish?

I have also written a few others that, after being cleaned-up a little, would make nice additions too.

I also ran into an issue like #8 but for ExAws.RDS.modify_db_instance/2:

iex(29)> with instance_id     = "some-instance-id",
...(29)>      new_instance_id = "#{instance_id}-new" do
...(29)> 
...(29)>   ExAws.RDS.modify_db_instance(
...(29)>     instance_id,
...(29)>     new_db_instance_identifier: new_instance_id
...(29)>   )
...(29)> 
...(29)> end
%ExAws.Operation.RestQuery{
  action: nil,
  body: "",
  http_method: :patch,
  params: %{
    "Action" => "ModifyDBInstance",
    "DBInstanceIdentifier" => "some-instance-id",
    "NewDbInstanceIdentifier" => "some-instance-id-new",
    "Version" => "2014-10-31"
  },
  parser: &ExAws.Utils.identity/2,
  path: "/",
  service: :rds
}

Per the AWS RDS API docs, the parameter should be named "NewDBInstanceIdentifier".

That seems to be a somewhat common issue with parameter names that include an acronym, e.g. "DB", or "AZ".

I also had some trouble with the "VpcSecurityGroupIds.*" parameter(s) for the AWS RDS API action "RestoreDBInstanceFromDBSnapshot". Those are also used by create_db_instance/7 but normalize_opts doesn't seem to handle them correctly. Some code I wrote for those parameters:

          vpc_security_group_ids
          |> Enum.with_index(
            fn group_id, index ->
              {
                "VpcSecurityGroupIds.VpcSecurityGroupId.#{index + 1}",
                group_id
              }
            end
          )
          |> Enum.into(%{})

That also seems like a possibly somewhat common pattern for the various 'collection' parameters for different functions, and probably in any other AWS API with 'AWS API Query' actions/endpoints.

I'm currently working with this library pretty heavily and this would be a good time – for me – to contribute, if you're open to contributions.

Hey @sashaafm, per https://elixirforum.com/t/proposal-exaws-2-0/9269 the ExAws project is splitting out each service into its own project.

You are the original contributor the RDS service to ExAws. If you wish to be its maintainer, please let me know and I will give you commit access to this repository. If you do not want this, let me know and I will look for someone else.

Thank you!

We need list_tags_for_resource in our organization. Its a useful function since its the only way to get the RDS tags and all our resource management and discovery of ownership revolves around tags. I'm creating this issue because I'm about to do a pull request that adds the function.

RDS added support for connecting with IAM credentials instead of long-lived credentials. This consists of generating a presigned URL - while this isn't an endpoint of the RDS API, I think it makes sense to add this here similar to the presigned URL support in ex_aws_s3.

http://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.IAMDBAuth.Connecting.html
http://docs.aws.amazon.com/cli/latest/reference/rds/generate-db-auth-token.html

This requires a corresponding change in ExAws.Auth.

It would be nice to add "proxy methods" like describe-db-proxy-endpoints, describe-db-proxy-targets to the library.

Option to describe_db_instances doesn't return expected values.

The following code will work:

  def describe_rds_instance(rds_db_identifier, keys) do 
    options = [{:DBInstanceIdentifier,  rds_db_identifier}]
    ExAws.RDS.describe_db_instances(options) |> ExAws.request(keys)
  end

but describe_db_instances_opts type has:

{:db_instance_identifier, binary}

If this is passed in as a parameter its ignored and every RDS instance for your requested account/region will be returned. The code currently ends up sending "DbInstanceIdentifier" and since the API is case-sensitive it doesn't match on this key.