Coder Social home page Coder Social logo

mc-musketmod's People

Contributors

ewewukek avatar lilypuree avatar pikachugabe avatar skpc9 avatar xannosz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

mc-musketmod's Issues

[Bug] ClassCastException on rendering PlayerEntity in 3rd Person

Versions

  • Minecraft: 1.16.5
  • Forge: 36.2.0
  • musketmod-1.16.5-forge-1.4.1
  • Werewolves: 1.8-0.5.6
  • Vampirism: 1.8.4

For reference: TeamLapen/Werewolves#65
I have gotten a crash-report from someone who uses this mod and my werewolves mod together. This is caused because i render the player with a werewolf model instead of the player model, resulting in a ClassCastException here

public static void onRenderLivingEventPre(final RenderLivingEvent.Pre<PlayerEntity, PlayerModel<PlayerEntity>> event) {

While testing i noticed that the RenderLivingEvent.Pre does not care about the generic parameter (it is too costly for forge to fire generic aware events) thus every eventhandler receives events for all entities and all models.

It may seem to be unnecessary for checking if the model is a PlayerModel if the entity is a player, but is it possible.

Curseforge page is marked as being a Fabric mod?

Apparently this mod is showing up as a Fabric mod on Curseforge, even though it does not appear to support Fabric right now. This can be observed by going to the Armor, Tools and Weapons tab in Curseforge, setting the "Version" drop-down to "Fabric", and clicking through until you find the mod (as of writing, it appears at the top of page 3).

I don't know how to fix this. I suspect there was an earlier version that supported Fabric at some point, which is marking the whole mod as supporting Fabric, even though current versions are only for Forge. Maybe this is a glitch on Curseforge's end. Goodness knows Curseforge is doing a poor job of helping people filter mods by what modloader they support...

Bayonet musket scaling issue + proposition

As in the title, musket with bayonett is extremely small when shown as model (in my case when used with Back Slot mod, but that's also semi-issue in item frames etc.). I've noticed while snooping in the files and editing crafting recipes, that while musket and pistol are 16px textures while bayonet one is 32px which may be the cause of this minor inconvinience.

Now, to the proposition part - I'm hobbyist pixel "artist" and in the heat of the moment I re-did mod's sprites (in 16px, including the bayonet one). If you'd like them, I'd have no issue with you using them. Preview image below:
image

If you like them and you'd like to use them, let me know, I'll send you the .png's. Thanks for the mod!

PS Config option for reloading time would be awesome.

Crash on Fabric

Duuno what's the problem but looking on the log seem trivial (seems at least, tho we all know how it may look ;-) )
Anyway symptoms are simple as well... I get crash on the very start.
here's log:

Text File.txt

Accessing LegacyRandomSource from multiple threads

Hello! I have some problem when using this mod

In singleplayer server (Creative mode) (fabric version, world type Amplified) after shot i was received the following error (with logout into main menu):

[21:22:58] [Netty Local Client IO #0/ERROR]: Thread dumps: 
Netty Local Client IO #0: 
	at java.base/java.lang.Thread.getStackTrace(Thread.java:1610)
	at net.minecraft.class_5798.method_39936(class_5798.java:92)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at net.minecraft.class_5798.method_33564(class_5798.java:82)
	at net.minecraft.class_5820.method_43156(class_5820.java:49)
	at net.minecraft.class_6566.method_43048(class_6566.java:33)
	at net.minecraft.class_761.method_3268(class_761.java:2790)
	at net.minecraft.class_761.method_3288(class_761.java:2760)
	at net.minecraft.class_761.method_8563(class_761.java:2731)
	at net.minecraft.class_761.method_8568(class_761.java:2726)
	at net.minecraft.class_638.method_8406(class_638.java:607)
	at ewewukek.musketmod.GunItem.fireParticles(GunItem.java:242)
	at ewewukek.musketmod.ClientSetup.lambda$onInitializeClient$2(ClientSetup.java:29)
	at net.fabricmc.fabric.impl.networking.client.ClientPlayNetworkAddon.receive(ClientPlayNetworkAddon.java:97)
	at net.fabricmc.fabric.impl.networking.client.ClientPlayNetworkAddon.receive(ClientPlayNetworkAddon.java:39)
	at net.fabricmc.fabric.impl.networking.AbstractChanneledNetworkAddon.handle(AbstractChanneledNetworkAddon.java:101)
	at net.fabricmc.fabric.impl.networking.client.ClientPlayNetworkAddon.handle(ClientPlayNetworkAddon.java:89)
	at net.minecraft.class_634.handler$bgn000$handleCustomPayload(class_634.java:2522)
	at net.minecraft.class_634.method_11152(class_634.java)
	at net.minecraft.class_2658.method_11457(class_2658.java:60)
	at net.minecraft.class_2658.method_11054(class_2658.java:8)
	at net.minecraft.class_2535.method_10759(class_2535.java:167)
	at net.minecraft.class_2535.method_10770(class_2535.java:152)
	at net.minecraft.class_2535.channelRead0(class_2535.java:50)
	at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
	at io.netty.channel.local.LocalChannel.readInbound(LocalChannel.java:299)
	at io.netty.channel.local.LocalChannel.finishPeerRead0(LocalChannel.java:445)
	at io.netty.channel.local.LocalChannel.access$400(LocalChannel.java:50)
	at io.netty.channel.local.LocalChannel$5.run(LocalChannel.java:403)
	at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174)
	at io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at java.base/java.lang.Thread.run(Thread.java:833)

[21:22:58] [Netty Local Client IO #0/ERROR]: Encountered exception while handling in channel with name "musketmod:smoke_effect"
net.minecraft.class_148: Accessing LegacyRandomSource from multiple threads
	at net.minecraft.class_761.method_8563(class_761.java:2740) ~[client-intermediary.jar:?]
	at net.minecraft.class_761.method_8568(class_761.java:2726) ~[client-intermediary.jar:?]
	at net.minecraft.class_638.method_8406(class_638.java:607) ~[client-intermediary.jar:?]
	at ewewukek.musketmod.GunItem.fireParticles(GunItem.java:242) ~[musketmod-1.19.2-fabric-1.4.4.jar:?]
	at ewewukek.musketmod.ClientSetup.lambda$onInitializeClient$2(ClientSetup.java:29) ~[musketmod-1.19.2-fabric-1.4.4.jar:?]
	at net.fabricmc.fabric.impl.networking.client.ClientPlayNetworkAddon.receive(ClientPlayNetworkAddon.java:97) ~[fabric-networking-api-v1-1.2.5+c6af733c90-ec866652fb51a93a.jar:?]
	at net.fabricmc.fabric.impl.networking.client.ClientPlayNetworkAddon.receive(ClientPlayNetworkAddon.java:39) ~[fabric-networking-api-v1-1.2.5+c6af733c90-ec866652fb51a93a.jar:?]
	at net.fabricmc.fabric.impl.networking.AbstractChanneledNetworkAddon.handle(AbstractChanneledNetworkAddon.java:101) [fabric-networking-api-v1-1.2.5+c6af733c90-ec866652fb51a93a.jar:?]
	at net.fabricmc.fabric.impl.networking.client.ClientPlayNetworkAddon.handle(ClientPlayNetworkAddon.java:89) [fabric-networking-api-v1-1.2.5+c6af733c90-ec866652fb51a93a.jar:?]
	at net.minecraft.class_634.handler$bgn000$handleCustomPayload(class_634.java:2522) [client-intermediary.jar:?]
	at net.minecraft.class_634.method_11152(class_634.java) [client-intermediary.jar:?]
	at net.minecraft.class_2658.method_11457(class_2658.java:60) [client-intermediary.jar:?]
	at net.minecraft.class_2658.method_11054(class_2658.java:8) [client-intermediary.jar:?]
	at net.minecraft.class_2535.method_10759(class_2535.java:167) [client-intermediary.jar:?]
	at net.minecraft.class_2535.method_10770(class_2535.java:152) [client-intermediary.jar:?]
	at net.minecraft.class_2535.channelRead0(class_2535.java:50) [client-intermediary.jar:?]
	at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.channel.local.LocalChannel.readInbound(LocalChannel.java:299) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.channel.local.LocalChannel.finishPeerRead0(LocalChannel.java:445) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.channel.local.LocalChannel.access$400(LocalChannel.java:50) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.channel.local.LocalChannel$5.run(LocalChannel.java:403) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174) [netty-common-4.1.77.Final.jar:?]
	at io.netty.channel.DefaultEventLoop.run(DefaultEventLoop.java:54) [netty-transport-4.1.77.Final.jar:?]
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995) [netty-common-4.1.77.Final.jar:?]
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) [netty-common-4.1.77.Final.jar:?]
	at java.lang.Thread.run(Thread.java:833) [?:?]
Caused by: java.lang.IllegalStateException: Accessing LegacyRandomSource from multiple threads
	at net.minecraft.class_5798.method_33564(class_5798.java:84) ~[client-intermediary.jar:?]
	at net.minecraft.class_5820.method_43156(class_5820.java:49) ~[client-intermediary.jar:?]
	at net.minecraft.class_6566.method_43048(class_6566.java:33) ~[client-intermediary.jar:?]
	at net.minecraft.class_761.method_3268(class_761.java:2790) ~[client-intermediary.jar:?]
	at net.minecraft.class_761.method_3288(class_761.java:2760) ~[client-intermediary.jar:?]
	at net.minecraft.class_761.method_8563(class_761.java:2731) ~[client-intermediary.jar:?]
	... 32 more

Used mods:

	- advanced_runtime_resource_pack 0.6.4
	- ae2 12.8.2-beta
	- ae2wtlib 12.7.0
	- appleskin 2.4.1+mc1.19
	- architectury 6.2.46
	- armorrenderlib 0.2.6 via relicex
	- attributefix 17.1.3
	- autopath 1.4.9
	- badpackets 0.2.0
	- basicshields 1.4.0-pre2-1.19.2
	- betteradvancements 0.2.2.142
	- betterdroppeditems 1.4.1-1.19
	- betterfpsdist 1.19.1-1.9
	- blockus 2.5.2+1.19.2
	- blue_endless_jankson 1.2.1 via owo
	- bookshelf 16.1.6
	- botanypots 9.0.7
	- botanytrees 5.0.1
	- cacao 1.2
	- cardinal-components-base 5.0.2 via playerex
	- cardinal-components-block 5.0.1 via polymorph
	- cardinal-components-entity 5.0.2 via playerex
	- cardinal-components-item 5.0.1 via polymorph
	- charmofundying 6.0.0+1.19.2
	- chisel 1.4.6
	- clear-skies 2.0.95
	- cloth-basic-math 0.6.1 via cloth-config
	- cloth-config 8.1.77 via fabricshieldlib
	- clumps 9.0.0+11
	- columns 1.5.1
	- com_electronwill_night-config_core 3.6.5 via couplings
	- com_electronwill_night-config_toml 3.6.5 via couplings
	- com_eliotlash_mclib_mclib 19 via geckolib3
	- com_eliotlash_molang_molang 19 via geckolib3
	- com_github_llamalad7_mixinextras 0.0.12 via debugify
	- com_logisticscraft_occlusionculling 0.0.6-SNAPSHOT via entityculling
	- com_moandjiezana_toml_toml4j 0.7.2 via dynamicfps
	- com_typesafe_config 1.4.1 via croptopia
	- consistency_plus 0.5.1+1.19.2
	- continuity 2.0.1+1.19
	- couplings 1.9.1+1.19
	- croptopia 2.1.0
	- crowdin-translate 1.4+1.19 via basicshields
	- dataattributes 1.2.7
	- debugify 2.7.1
	- decorative_blocks 3.0.0
	- dehydration 1.3.1
	- detailab 2.6.2+1.19-fabric
	- dynamicfps 2.2.0
	- editsign 2.6.0
	- elytraslot 6.0.0+1.19.2
	- enchant_giver 1.3.0 via mcdw
	- enchdesc 13.0.6
	- entityculling 1.5.2-mc1.19
	- equipmentcompare 1.3.1
	- error_notifier 1.0.9 via roughlyenoughitems
	- fabric-api 0.62.0+1.19.2
	- fabric-api-base 0.4.12+93d8cb8290 via fabric-api
	- fabric-api-lookup-api-v1 1.6.10+93d8cb8290 via fabric-api
	- fabric-biome-api-v1 9.0.18+c6af733c90 via fabric-api
	- fabric-blockrenderlayer-v1 1.1.21+c6af733c90 via fabric-api
	- fabric-client-tags-api-v1 1.0.2+b35fea8390 via fabric-api
	- fabric-command-api-v1 1.2.12+f71b366f90 via fabric-api
	- fabric-command-api-v2 2.1.8+93d8cb8290 via fabric-api
	- fabric-commands-v0 0.2.29+df3654b390 via fabric-api
	- fabric-containers-v0 0.1.35+df3654b390 via fabric-api
	- fabric-content-registries-v0 3.3.1+624e468e90 via fabric-api
	- fabric-convention-tags-v1 1.1.2+93d8cb8290 via fabric-api
	- fabric-crash-report-info-v1 0.2.6+aeb40ebe90 via fabric-api
	- fabric-data-generation-api-v1 5.2.0+b598f4ac90 via fabric-api
	- fabric-dimensions-v1 2.1.32+0dd10df690 via fabric-api
	- fabric-entity-events-v1 1.4.19+9ff28f4090 via fabric-api
	- fabric-events-interaction-v0 0.4.29+c6af733c90 via fabric-api
	- fabric-events-lifecycle-v0 0.2.29+df3654b390 via fabric-api
	- fabric-game-rule-api-v1 1.0.22+c6af733c90 via fabric-api
	- fabric-item-api-v1 1.5.8+93d8cb8290 via fabric-api
	- fabric-item-groups-v0 0.3.30+93d8cb8290 via fabric-api
	- fabric-key-binding-api-v1 1.0.21+93d8cb8290 via fabric-api
	- fabric-keybindings-v0 0.2.19+df3654b390 via fabric-api
	- fabric-language-kotlin 1.8.4+kotlin.1.7.20
	- fabric-lifecycle-events-v1 2.2.0+33ffe9ec90 via fabric-api
	- fabric-loot-api-v2 1.1.4+83a8659290 via fabric-api
	- fabric-loot-tables-v1 1.1.7+9e7660c690 via fabric-api
	- fabric-message-api-v1 5.0.4+93d8cb8290 via fabric-api
	- fabric-mining-level-api-v1 2.1.15+33fbc73890 via fabric-api
	- fabric-models-v0 0.3.18+c6af733c90 via fabric-api
	- fabric-networking-api-v1 1.2.5+c6af733c90 via fabric-api
	- fabric-networking-v0 0.3.22+df3654b390 via fabric-api
	- fabric-object-builder-api-v1 4.0.12+93d8cb8290 via fabric-api
	- fabric-particles-v1 1.0.11+79adfe0a90 via fabric-api
	- fabric-registry-sync-v0 0.9.26+c6af733c90 via fabric-api
	- fabric-renderer-api-v1 1.0.11+c6af733c90 via fabric-api
	- fabric-renderer-indigo 0.6.13+aeb40ebe90 via fabric-api
	- fabric-renderer-registries-v1 3.2.21+df3654b390 via fabric-api
	- fabric-rendering-data-attachment-v1 0.3.15+aeb40ebe90 via fabric-api
	- fabric-rendering-fluids-v1 3.0.8+c6af733c90 via fabric-api
	- fabric-rendering-v0 1.1.23+df3654b390 via fabric-api
	- fabric-rendering-v1 1.11.0+73145abb90 via fabric-api
	- fabric-resource-conditions-api-v1 2.0.12+a29562c890 via fabric-api
	- fabric-resource-loader-v0 0.7.0+93d8cb8290 via fabric-api
	- fabric-screen-api-v1 1.0.27+93d8cb8290 via fabric-api
	- fabric-screen-handler-api-v1 1.3.1+1cc24b1b90 via fabric-api
	- fabric-textures-v0 1.0.21+aeb40ebe90 via fabric-api
	- fabric-transfer-api-v1 2.1.1+93d8cb8290 via fabric-api
	- fabric-transitive-access-wideners-v1 1.3.1+42d99c3290 via fabric-api
	- fabricloader 0.14.9
	- fabricshieldlib 1.6.0-1.19
	- fake-player-api 0.4.0 via indrev
	- fallingleaves 1.12.2+1.19.2
	- fallingtree 3.9.2
	- farsight 1.19-2.1
	- fiber 0.23.0-2 via patchouli
	- forgeconfigapiport 4.2.6
	- fwaystones 3.0.5+mc1.19.2
	- geckolib3 3.1.23
	- glassdoor 3.1.0-beta.1+1.19
	- graveyard 2.0
	- grindenchantments 2.0.0-beta.2+1.19.2
	- iceberg 1.0.46
	- imm_ptl_core 2.2.5 via immersive_portals
	- immersive_portals 2.2.5
	- imst 2.0.3
	- indium 1.0.9+mc1.19.2
	- indrev 1.15.1-BETA
	- inventoryhud 3.4.2
	- inventoryprofilesnext 1.8.2
	- io_github_douira_glsl-transformer 1.0.0-pre21.2 via iris
	- io_leangen_geantyref_geantyref 1.3.11 via croptopia
	- iris 1.4.0
	- ironchests 1.7.7
	- jankson 4.1.1+j1.2.1 via libgui
	- java 17
	- lambdabettergrass 1.3.0+1.19
	- lambdynlights 2.1.2+1.19
	- lazydfu 0.1.3
	- libgui 6.2.0+1.19 via ironchests
	- libipn 1.0.3
	- libninepatch 1.1.0 via libgui
	- lithium 0.9.1
	- magna 1.8.0-1.19 via modern_industrialization
	- mcda 2.2.0
	- mcdar 1.5.2-1.19
	- mcdw 5.0.4-1.19
	- mcwbridges 2.0.5
	- mcwdoors 1.0.7
	- mcwfences 1.0.6
	- mcwlights 1.0.4
	- mcwtrpdoors 1.0.7
	- mcwwindows 2.0.3
	- medievalweapons 1.4.1
	- megane 8.3.0
	- megane-api 8.3.0 via megane
	- megane-applied-energistics-2 8.3.0 via megane
	- megane-fabric-transfer 8.3.0 via megane
	- megane-industrial-revolution 8.3.0 via megane
	- megane-reborn-core 8.3.0 via megane
	- megane-reborn-energy 8.3.0 via megane
	- megane-runtime 8.3.0 via megane
	- megane-tech-reborn 8.3.0 via megane
	- megane-vanilla 8.3.0 via megane
	- minecraft 1.19.2
	- mm 2.3 via fabricshieldlib
	- modelfix 1.8
	- modern_industrialization 1.3.2
	- modmenu 4.0.6
	- moonlight 1.19.2-2.0.37
	- musketmod 1.4.4
	- mvs 2.5.9
	- nameplate 1.0.9
	- net_objecthunter_exp4j 0.4.8 via playerex
	- noindium 1.1.0+1.19 via ae2
	- omega-config 1.2.2-1.18.1 via graveyard
	- opc 0.6.4 via playerex
	- org_anarres_jcpp 1.4.14 via iris
	- org_antlr_antlr4-runtime 4.10.1 via iris
	- org_jetbrains_kotlin_kotlin-reflect 1.7.20 via fabric-language-kotlin
	- org_jetbrains_kotlin_kotlin-stdlib 1.7.20 via fabric-language-kotlin
	- org_jetbrains_kotlin_kotlin-stdlib-jdk7 1.7.20 via fabric-language-kotlin
	- org_jetbrains_kotlin_kotlin-stdlib-jdk8 1.7.20 via fabric-language-kotlin
	- org_jetbrains_kotlinx_atomicfu-jvm 0.18.3 via fabric-language-kotlin
	- org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm 1.6.4 via fabric-language-kotlin
	- org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 1.6.4 via fabric-language-kotlin
	- org_jetbrains_kotlinx_kotlinx-datetime-jvm 0.4.0 via fabric-language-kotlin
	- org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm 1.4.0 via fabric-language-kotlin
	- org_jetbrains_kotlinx_kotlinx-serialization-core-jvm 1.4.0 via fabric-language-kotlin
	- org_jetbrains_kotlinx_kotlinx-serialization-json-jvm 1.4.0 via fabric-language-kotlin
	- org_joml_joml 1.10.4 via sodium
	- org_spongepowered_configurate-core 4.1.2 via croptopia
	- org_spongepowered_configurate-hocon 4.1.2 via croptopia
	- owo 0.8.5+1.19
	- particlerain 2.0.0
	- patchouli 1.19.2-76-FABRIC
	- phosphor 0.8.1
	- placeholder-api 2.0.0-beta.7+1.19 via playerex
	- playerabilitylib 1.6.0 via modern_industrialization
	- playerex 3.3.7
	- polymorph 0.45.0+1.19.2
	- pride 1.1.2+1.19 via lambdynlights
	- q_misc_util 2.2.5 via immersive_portals
	- quarrymod 1.0.2
	- reach-entity-attributes 2.3.0 via mcdw
	- reborncore 5.3.4 via techreborn
	- redstonepen 1.2.18
	- relicex 3.2.5
	- roughlyenoughitems 9.1.550
	- roughlyenoughresources 2.6.0
	- rpgdifficulty 1.2.2
	- smoothchunk 1.19.1-2.0
	- sodium 0.4.4+build.18
	- spruceui 4.0.0+1.19 via lambdabettergrass
	- step-height-entity-attribute 1.0.0 via indrev
	- stonecutter_recipe_tags 4.0.0+1.19.9b8d04c.fabric via consistency_plus
	- supplementaries 1.19.2-2.2.6
	- team_reborn_energy 2.2.0 via modern_industrialization
	- techreborn 5.3.4
	- terraform-wood-api-v1 4.1.0 via blockus
	- toolleveling 1.19.2-1.4.1
	- trinkets 3.4.0
	- wthit 5.13.1
	- xaerominimap 22.16.0
	- xaeroworldmap 1.28.1
	- xps 0.4.6-r+1.19.2-Fabric
	- yet-another-config-lib 1.5.0

[Suggestion] Crafting Recipe, Paper Cartridge Texture and Third Person reload animation:

Firstly I would like to express my "love" for the mod. It's simple and it sticks to the mechanics and art style of the game.
Because of these features it can find it's way into any vanilla styled mod-pack.

However there are a few things that personally bug me and improvements that I feel could be made.

First of these things that I would like to bring up is the crafting recipe:

You are forced create two components, the Gun Barrel and the Gunstock, in order to craft yourself a Musket. These two components however are completely useless for anything else excluding the aforementioned Musket crafting recipe.
I would like to suggest changing the crafting recipe so that it would instead of requiring these useless components, instead use vanilla items, which would in turn further simplify the mod.
Screenshot_14
(Pictured above is my personal suggestion for the crafting recipe requiring only vanilla items)

Second thing that i would want to bring up is the fact that the paper cartridge has rims:

With rimmed ammunition being a staple of modern ammunition that uses metal casings, I strongly believe that the texture of the paper cartridge should be tweaked. Additionally to further fit the vanilla art style and to look less chonky in comparison to the musket itself the texture could be tweaked to be slightly angled to the right in the same fashion that arrows are.
Screenshot_15
(There are many variations of paper ammunition, my take, pictured above, is one that has the projectile covered as well)

The very last thing that I would want to bring up are the third person reload animations, or the lack of.

It might be just my game but when I reload the musket in third person there isn't an animation of any kind. This is quite glaring, especially in multiplayer. Adding a third person animation that matches the reload animation if first person would vastly improve the quality of the mod.

(Also as a side note please do capitalize the M in mod like a normal human being)
Screenshot_10

[REQUEST] Modrinth upload of pre-1.20.6 versions

As of right now, Modrinth only has versions 1.4.8 for Minecraft 1.20.6 and after. 52 more mod versions is probably a lot to upload to be fair, so feel free to decline this.
Requesting on behalf of a friend so that they can upload a modpack to Modrinth for ease of access since they want to make a small server.

[Suggestion] Add more cool stuff

List:
Dynamite: Must ignite it first with flint and steel to throw it and explode for a second.
Can be obtain from tnt block by extracting it.

Smoke bomb: Receive invisibility for short period of time.

Bear trap: Mobs can't move if they get trapped for a while and receive slowness.

[Suggestion] Shotgun/Blunderbuss & Piercing ammo

I would ask if there is a plan to add a shotgun to this mod? I know you have antique shotgun mod but that mod is very different from this one.

Just adding a scatter ammo type would make reloading a pain. Having to move inventory around to load one gun with a single shot and the other with the scatter shot is not what you want to do in a tough fight. Being able to quickly reload each firearm individually from the hot bar, with no shuffling of items, would be ideal. So a firearm that only shoots scatter shot in the mod would be amazing!! It would be made simply like the others. (Which is where antique shotgun is kinda out of place) It would obviously have to be visually distinct from the musket to keep confusion down. A flared barrel like a blunderbuss?

All the normal configs would still make sense but might also add one for "Scatter range"(how wide the cone would be) and one for "pellet count"(how many projects are in said cone) perhaps.

I would be fine with just having the paper cartridge work in it. However, I could understand the idea of making a separate 'scatter cartridge' that only works in the blunderbuss might make more sense.

That brings me to my next idea. Piercing ammo!?
Either it goes the full range the firearm is set to in the config file (hitting all targets along the path) or a new config could be added to limit the piercing. (Only goes so far after hitting a target OR can only hit so many targets before it stops) Which ever is easier for you really would be cool imo.

I love this mod and will continue to use it. Yet, these two ideas would make it to where there is no chance of another mod outdoing it.

Musket bug

The version is 1.16.5. when I enchanted the musket with infinity, the musket consumed the bullet like a normal, un-enchanted one instead of not consuming it.

Commission

Is it possible that you can make this musket mod again but for a 1.17.1 bukkit plugin for my server? I would like to commission your work if possible!

crash problem

it crashes when I use the 1.18 forge version for a 1.18.2 forge alternos server. I have no other mods installed. it just crashes when I boot up the server. here is the error log: https://mclo.gs/vhx2a82#L32

Modrinth Upload

Could you be so kind and upload you mod to Modrinth too?
For me the Fabric version would be enough.

I would really like to use it in my mod(+modpack) and would love to give you more downloads :)
(I have another friend who made their pack on modrinth and would like to use it as well.)

(For the record and because I was asked: I know the MIT license would allow me to upload it there myself, but that would feel dirty and rob the author of all monetary benefits. So to all others apart from the author, please don't upload it just to fulfill my issue, unless there is no reply for more than two months.)

Request module interaction

The module I am requesting interaction with is (Guard Villagers).
The firearms in your mod are relatively similar to the original style, and the mechanism doesn't look complicated, so it should be relatively balanced.
This is really great!
And now in the hands of these villagers, it can only be used for close combat
Imagine how cool it would be when the gun in the guard's hand rings!

Compat Issue with First Person Model Mod

When using the musket with the first person model mod, after you reload it visibly seems to duplicate itself, with one musket being held properly according to the player model, and another floating as if in normal first-person perspective.
2021-08-14_22 04 28

Works 'normally' in the off hand (I'll be submitting a feature request for offhand capability shortly).
2021-08-14_22 04 37

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.