Rich-Click does not translate the ascii codes into colors on windows 64 cmd.exe anymore about rich-click

[dwreeves]

Interesting! 1.7.0 had a major shift in Rich-Click's internals, and I guess a few things fell under the cracks.

I'm not on Windows, but I think I see what the issue is: In 1.7.0, the config variable legacy_windows was added and its default is False, whereas its default should probably be None.

Can you confirm that the issue is fixed if you run the help text for the following?

import rich_click as click

@click.command()
@click.option("--count", default=1, help="Number of greetings.")
@click.option("--name", prompt="Your name", help="The person to greet.")
@click.rich_config(help_config=click.RichHelpConfiguration(legacy_windows=None))
def hello(count, name):
    """Simple program that greets NAME for a total of COUNT times."""
    for _ in range(count):
        click.echo(f"Hello, {name}!")

if __name__ == '__main__':
    hello()

Note the addition of @click.rich_config(help_config=click.RichHelpConfiguration(legacy_windows=None)). I do agree that, since Rich auto-detects this for users, this implies None should be the default.

[djkawa]

yes! adding:

@click.rich_config(help_config=click.RichHelpConfiguration(legacy_windows=None))

to all the commands in 01_simple.py fixed it.

Well done!

[dwreeves]

@djkawa legacy_windows is now by default set to None in the latest release of rich-click, 1.7.4. So you don't need to use the @rich_config() decorator anymore. Thanks for opening this issue!