evojam / play-elastic4s Goto Github PK

It says "Elastic4s bindings for Play 2.4.x and above".
But it only supports play 2.5.x as described in the readme...

The Scaladoc for the module should be published somewhere for easy reference and linked to from readme file.
The docs should be updated automatically with release (from Travis? on sonatype update? on push-to-master?)

Currently NotAJsObjectException extends Exception, I would rather use IllegalArgumentException as a parent class.

According to build settings:

1. the latest version is 0.3.1 which should be considered stable
2. dependency elastic4s-core version is 2.3.0 which supports ES 2.3.X

We should be more clear on how to provide configuration for an index type and what each field represents.

I would like to execute bulk index with id for each document, currently it's not exposed (I have to use underlying).

We should wrap all CRUD operations on Elastic with Play JSON support.

We don't close ES client when application tries to stop. We should enforce shutdown and test against misconfigured cluster/node, version match, etc. What I have experienced was a must use kill -9 issues with when node ES version did not match ES cluster. Did not try with valid setup yet.

Naming convention is index instead of insert. Bulk operation is called bulkInsert, should be renamed to bulkIndex to keep consistency.

When injecting the ElasticSearchClient from this module there is no access to underlying: ElasticClient.