everythingme / ffos-notes Goto Github PK

Steps To Reproduce (STR):

1. In the FFOS Simulator, load the app with error console.
2. Click plus sign in top right

Expected:
New note created

Actual:
JS error: ReferenceError: enml not defined line 583

Looks like emnl is defined in js-binary/enml-js/enml.js

but

is not going to work correctly because of the asterisk.

For instance, what the hell is this.

Remove code that has been commented out from the code base. If you need to keep previous examples around, refer to diffs between patches. ex.

Because types in JavaScript are loosely defined and be coerced at runtime this line can be rewritten:

if (oauthtoken && noteStoreUrl && shardUrl) {

if any of the above are undefined or the empty string, those values are falsy and evaluate to false. Please do not ever do variable != 'undefined'

$ find . -perm -755 -type f -not -iwholename '*.git*'

should all be chmod 644'ed

$ find . -perm -755 -type f -not -iwholename '*.git*' | xargs -P 4 chmod 644 would do the trick

could a switch statement help here?

In JS, you may switch on strings.

The required translations for pre-installed applications are English, Spanish, Portuguese, Polish, Croatian, Czech, German, Hungarian, and Romanian.

Most of gaia uses the webL10N library and I've used it as well. I would recommend it.

Don't worry about prettifying HTML. Just use JSON.stringify(responseData)

FINALLY today we have learned why the notes app has been stuck in the marketplace review queue forever... Because the gh-pages branch is not completely up to date! The latest commit to the manifest file, hilariously enough, intentionally adds an error to the manifest file... Which causes it to fail review.

ownCloud also has a Notes app with an API: https://github.com/owncloud/notes/wiki/API-0.2 – we also support WebDAV, and use plaintext files in the »Notes« subfolder.

Would be cool if the Firefox OS Notes app would support that as well since ownCloud gets more and more widespread and is open source software you can host yourself. You can see more info about the app at http://apps.owncloud.com/content/show.php/Notes?content=160567

If you have any questions, @Raydiation is the developer of ownCloud Notes and the API. Would be cool to get that going to forward sync with open platforms next to Evernote.

is then called again on the next line. Don't Repeat Yourself

Delete a note
Enter "Trash" folder
Sort by anything

it seems like it shows all the notes, regardless of notebooks or trashed status.

notes.js introduces a ton of variables into the global namespace. Sure it may be the last included script and it may work now, but that doesn't make for very maintainable JS. Please wrap it in a self executing anonymous function.

STR:
!. Start app in simulator.
2. Click top left button
3. Click Connect with Evernote

Expected: Evernote banner along top

Actual: Unnecessary URL along top

STR:

1. Open app in FFOS simulator
2. Click top left button
3. Click Connect with Evernote
4. Scroll to bottom and click on ToS or PP

Expected: ToS or PP presented

Actual: Nothing

The code looks for a url, but the activity now returns a blob.

In common.js, in actionPhoto:

                if (!act.result.url) return;

The act.result object now looks like:

{"type": "image/jpeg", "blob", blob_obj}

Therefore even though the image is picked successfully, the early-exit is hit because there is no url property of the result, and thus nothing happens.

Also, the "reopenApp" function does not appear to be required -- Removing it makes no difference, once the image is picked the notes app is loaded even without the reopenApp code.

Memory is cheap, maintaining code is not:
Instead of passing an object literal in a nice one liner, the code is more readable if you declare the object on the previous line.

JavaScript is a loosely typed language, and implicit conversions can rear their head at the most unfortunate times. Please always use === or !== in conditionals in notes.js.

These three lines are doing the exact same thing, move them into a function.