Coder Social home page Coder Social logo

Comments (3)

barsnick avatar barsnick commented on September 3, 2024

Hello @gaohtao,
you are absolutely right. current_octet is only promoted to int automatically, when shifting. It needs to be typecasted directly.

We need to review the remaining code, and create a test case for this.

I guess in ISO 15118-2, TMeter and EVSETimeStamp are affected. What did you notice this with?

from cbexigen.

gaohtao avatar gaohtao commented on September 3, 2024

I tested ISO15118-2 protocol SessionSetupRes command, which contains a timestamp defined as int64, I intentionally filled in the timestamp as largeInteger, and I found that the decoded number is wrong.
"{"V2G_Message": {"Header": {"SessionID": "C08CDF36985A7190"}, "Body": {"SessionSetupRes": {"ResponseCode": "OK_NewSessionEstablished", "EVSEID": "UK123E1234", "EVSETimeStamp": 1234567890123456789}}}}";

from cbexigen.

barsnick avatar barsnick commented on September 3, 2024

This should be fixed on branch main with commit ae4f37e. Please be so kind to test.

Thanks for your report!

from cbexigen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.