eventbrite / currint Goto Github PK

currint version: 1.6.1

Currency.format_decimal returns an incorrect value if divisor is set, and it is not a power of 10. Instead of returning a decimal number representing the fractional number of major units, it returns the number of minor units on the right side of the decimal.

This impacts currencies like the Mauritanian ouguiya (MRO), whose minor unit is 1/5th the value of the major unit (1.2 ouguiya (major) = 6 khoum (minor)). For example, currencies['MRO'].format_decimal(6) produces '1.1' (1 ouguiya and half a khoum) instead of '1.2'.

To reproduce:

from currint import currencies

currencies['MRO'].format_decimal(6)
# '-1.1' 😞

# Passing back in the result of `format_decimal` into `major_to_minor_value` raises a value error
# ".1" is intepreted as half a khoum
currencies['MRO'].major_to_minor_value(Decimal('1.1'))
# ValueError: Cannot convert major amount Decimal('1.1') to minor amount; would result in fractional amount of minor unit)

currint version: 1.6.1

Passing a negative value less than 0 and greater than -1 major units to Currency.format_decimal will return a string formatted as a positive value.

To reproduce:

from currint import currencies

currencies['USD'].format_decimal(-100)
# u'-1.00' 👍

currencies['USD'].format_decimal(-99)
# u'0.99' 😢

currint version: 1.6.1

Currency.format includes a trailing dot 0 (".0") for currencies with a 0 exponent (a la ¥). Currencies without a minor unit (0 exponent) should return a whole number without the trailing ".0".

To reproduce:

from currint import currencies

currencies["JPY"].format(100)
# "100.0 JPY"