evanoberholster / timezonelookup Goto Github PK

Thanks for all the fine work on this lib. I'm very interested in using v2 but unfortunately I'm unable to import it in its current form. I think these instructions would be of help...

https://therootcompany.com/blog/bump-go-package-to-v2/

After go.mod is adjusted you'll need to reset the v2.0.0 tag. IIRC in order to delete a remote tag on github you'll need to run git push origin :v2.0.0

Hi,

I wrote a package https://github.com/ringsaturn/tzf and add a benchmark page compard with this repo https://github.com/evanoberholster/timezoneLookup .

Benchmark shows that timezoneLookup which use RTree is slower 20 times compared with tzf which only use point in polygon search algo from https://github.com/tidwall/geojson

The performance seems comfusing because RTree should be faster, is there anything i missed in the benchmark code?

Benchmark repo https://github.com/ringsaturn/tz-benchmark

Bencmark pages https://ringsaturn.github.io/tz-benchmark/

This doesn't seem to function when run on Windows.

# github.com/evanoberholster/timezoneLookup/v2
C:\Users\Nathan Fiscaletti\go\pkg\mod\github.com\evanoberholster\timezone!lookup\[email protected]\timezone.go:222:17: undefined: syscall.Mmap
C:\Users\Nathan Fiscaletti\go\pkg\mod\github.com\evanoberholster\timezone!lookup\[email protected]\timezone.go:222:64: undefined: syscall.PROT_READ
C:\Users\Nathan Fiscaletti\go\pkg\mod\github.com\evanoberholster\timezone!lookup\[email protected]\timezone.go:222:80: undefined: unix.MAP_SHARED
C:\Users\Nathan Fiscaletti\go\pkg\mod\github.com\evanoberholster\timezone!lookup\[email protected]\timezone.go:227:17: undefined: syscall.Munmap

Any plans to add windows support?

Timezone definition does not work at a point
Lon: 113.80151000
Lat: 26.82077200