etsap-times / times_model Goto Github PK

This issue has been reported in kanors-emr/Veda2.0-Installation#26
TIMES related input for reproducing the issue is submitted here.

In prepxtra.mod a put_utility 'shell' is used to rename the _dd_.gdx file and store it in a different location with a file name that contains some kind of time stamp. This saving of the _dd_.gdx which is created and handled at compile time is done at execution time. Due to GAMS save/restart capabilities the compile and execution phase can happen at very different times and even on different machines. It would be cleaner if the saving of this file is done in the compilation phase of GAMS.

In err_stat.mod the file SCREEN uses file name CON to write to the console. I guess the intention on the SCREEN file is to write messages from TIMES to the GAMS log. This works okay on Windows with lo=1 (the current default). A much better way is to use the empty string as a file name (FILE SCREEN / '' /;). This works platform independent and writes to the GAMS log independent of if this goes to con or /dev/tty, stdout, or a log file.

@robbiemorrison pointed out elsewhere that Github doesn't seem to recognise the license under which TIMES is released. Since then something has changed (?) and Github now shows both an unknown (for LICENSE.txt) and GPL-3.0 (for COPYING.txt) licenses.
@Antti-L , @ggiannakidis, as far as I understand LICENSE.txt contains both a copyright and a license notice, while the license itself is in COPYING.txt. @Antti-L I guess, LICENSE.txt is also used for the startup notice? Do you think LICENSE.txt should be renamed or the notices it contains should be included elsewhere?

I cloned the repo, unpacked the zip archive, and started gams with gams maindrv.mod as well gams maindrv.mod r=_times in both cases I get

--- maindrv.mod(23) 2 Mb
--- . setglobs.gms(59) 2 Mb
--- maindrv.mod(43) 2 Mb
***
*** Abort "*** ERRORS IN INPUT DATA/COMPILE ***"
--- maindrv.mod(43) 3 Mb 2 Errors
*** Status: Compilation error(s)
--- Job maindrv.mod Stop 01/21/20 08:17:59 elapsed 0:00:00.018

The first error is about a set j:

 572  SET SOLVESTAT(J) /
****                $120

I did not find a short description how to get the model to run with GAMS. Can someone point me to something like a (quick start) guide.

BTW, for git and pull requests it might be much better to have the source files directly in the repo rather than the source files in a zip archive.