ets / hishare Goto Github PK

The purpose of both a Service and a Manager layer is unclear - document the differences and/or consider collapsing it into one layer.

One of the benefits of Spring IOC is that bean lifecycle is guaranteed. As such we generally want to steer away from constructor injection and instead rely upon individual setters for configuring our beans. Default values for a class should be implemented by declaring an initial value for each property.

Currently, constructor injection is used for several of our beans and we should refactor them to use discrete setters instead.

e.printStackTrace() writes to standard out which isn't as useful in a web stack as taking advantage of log4j's stacktrace recording capabilities.

Convert calls to e.printStackTrace() and instead pass the Exception as the second parameter to the corresponding error message like so:

log.error("Your custom error message for the log",e); //The exception pass as the second parameter will have its stacktrace written to the log

Configure the maven pom to publish javadocs and related info to the gh-pages branch

See http://pages.github.com/ for details

Rewrite some of the code in Scala if possible.

We should rid ourselves of several spring xml files by moving to annotation defined beans.

Interfaces generally define contracts that are implementation agnostic. We currently have two sets of interfaces under our managers package and our service package. The http and remoting interfaces should be merged to provide a common interface to both implementations.

http://static.springsource.org/spring/docs/1.2.x/api/org/springframework/web/multipart/MultipartFile.html states that "The file contents are either stored in memory or temporarily on disk," look into whether this breaks encryption at rest, and what can be done to protect from that.