ethjs-unit

Issue Type

• [x ] Bug (https://github.com/ethjs/ethjs-unit/blob/master/.github/CONTRIBUTING.md#bug-reports)
• Feature (https://github.com/ethjs/ethjs-unit/blob/master/.github/CONTRIBUTING.md#feature-requests)

Description

We would like to gain insight into the process for pegging our non-native token to ETH @ a price of 3.52594389518074 Wei for pricing on our Dapp w/o traditional liquidity pools. Any guidance would be awesome.

Warmest Regards

Issue Type

• Bug (https://github.com/ethjs/ethjs-unit/blob/master/.github/CONTRIBUTING.md#bug-reports)
• Feature (https://github.com/ethjs/ethjs-unit/blob/master/.github/CONTRIBUTING.md#feature-requests)

Description

The toWei() function will return incorrect results when passing numbers smaller than 1e-6 to it.

For example toWei(1e-7, 'gwei').toString() will return 2377000000000 instead of 100.

The issue starts here and then cascades downward. The problem is that you are using the String constructor to convert number to a string. However, it will produce some small numbers in exponential notation instead of the fixed notation that you are expecting.

Steps to reproduce

Check the PR #7.

Versions

Doesn't matter.

Someone already made a PR but I see this package not being updated for a long time.

We are shipping 6 versions of bn.js because crypto dev aren't updating their dependencies !

Issue Type

• Bug (https://github.com/ethjs/ethjs-unit/blob/master/.github/CONTRIBUTING.md#bug-reports)
• Feature (https://github.com/ethjs/ethjs-unit/blob/master/.github/CONTRIBUTING.md#feature-requests)

Description

#toWei breaks for decimal inputs of "wei" and "noether"

Steps to reproduce

// these *should* throw errors
unit.toWei(0.1, 'noether') // 1
unit.toWei(0.1, 'wei') // 1

Note that larger denominations work fine

// these work as expected
unit.toWei(0.1, 'kwei') // 100
unit.toWei(0.001, 'kwei') // 1
unit.toWei(0.0001, 'kwei') // throws error