ethers-io / ethers-cli Goto Github PK

ethers-ens provides set-text, set-content, ... but no mechanism to read these.

https://docs.ethers.io/ethers-app/dev-cli.html

404 Not Found

Code: NoSuchKey
Message: The specified key does not exist.
Key: ethers-app/dev-cli.html
RequestId: EE8B45476E575546
HostId: IIr0aFTtLjqX95wVP/y8QWwL8K2j/otqiFTTKXGle1evVzsEEvuTpE8s972tid83hFg0LBy6efw=
An Error Occurred While Attempting to Retrieve a Custom Error Document

Code: NoSuchKey
Message: The specified key does not exist.
Key: error.html

Some network include a non-official ens deployment, which is not at the "common" address. ethers-ens (from the cli package) can connect to any network, using the --rpc URL option, which is great, but there is currently no way to set the ensregistry.

This would be very usefull to script ens maintenance operations on sidechains and OVM layer 2.

Describe the bug
trying to set an IPNS hash as content fails with Error: Non-base58 character

Reproduction steps
ethers-ens set-content name.eth k51qzi5uqu5dmgyzzlivmvyqkhv2zj8zth8vpmvqvihontt72p32aaybc83fqc

Search Terms
ipns

Please consider:

• adding the setName method (already in the SetNamePlugin) to the help/usage screen
• adding a feature to register/setResolver for reverse names (through the reverse registrar)
• adding lookup function to read text entries (that have been set with --set-text) through the cli

Thank you :)

I'm using ethers-cli to deploy to a ganache-cli testrpc with the following command:

yarn ethers-deploy --gas-price 1 --gas-limit 250000000 --rpc http://localhost:8545 run deploy-contracts.js

the deploy-contracts.js file looks almost identical to: https://github.com/ethers-io/tutorial-simplestore/blob/master/deploy-contract.js except with my sol file

a few questions:

1. the generated contract json file from saveContract(..) has the abi inside the key “interface” but in your tutorial-simplestore/simple-store.json its called “abi” which is preferable — why would it be showing up as “interface” in that file output?

2. I noticed the "interface" value is a quoted string of the abi object, why use an escaped string instead of just the object itself? perhaps this is more convenient for other use or a mistake?

3. it would be nice to specify --network “any_name_i_want” to ethers-deploy as the network name is set as the root "key" of the contract json. Presently, the generated contract json lists "homestead" even though I'm specifying --rpc to a ganache local server

4. is there a way to link contract deployments..? similar to as truffle contract deployments.. or how do you recommend to deploy a contract that depends on other contracts?

5. can the builder.saveContract(..) method that saves the contract abi json, also include the bytecode and other contract details similar to how truffle's compilation works? perhaps with an option flag to this method?

6. during development, it would be nice to have quick iteration / rebuild, one of the slow parts is having to type the password for a test account.json keystore file between deploys, is there a way to tell ethers-deploy to use "empty-password" and skip the password request?

7. as well it would be nice to have a --yes flag to ethers-deploy for when it asks to "Send Transaction?" it would just specify yes always, this way a single yarn deploy command could be specified to do a full deploy during development

8. another good idea is to make "solc" a peer dependency instead of a dependency, this way users can upgrade solc on their own without having to wait for ethers-cli to publish a new version see https://nodejs.org/en/blog/npm/peer-dependencies/

9. for testing / dev, it would be nice to pass a mnemonic phrase for an account instead of a keystore file

The documentation of ethers-cli & ethers-ens, describes numerous ways to connect to an account. however, their doesn't appear to be a option of hardware wallets (ledger in my case). I believe using @ethersproject/hardware-wallets this is something that could be added pretty easily. I would definitelly have usecases for it!