ether / ep_font_family Goto Github PK

I noticed than HTML exports are broken in our instances since the 1.8.7 upgrade.

As we have a lot of plugins, I suspected a problem with a server hook on HTML export. I started from a fresh instance (Docker image etherpad/etherpad:1.8.7) and tested an HTML export. It worked.

I then installed ep_font_family plugin. From there, it is impossible to export a pad.

The logs will just drop something like

API - REQUEST, v1.2.14:getHTML, {"padID":"test","apikey":"XXX"}

and this will eventually end with a 502 error.

I can provide additional details if needed.
Thanks in advance!

Hi,

I have got an issue when I try to export pads with abiword.
When I export a pad which use a font of this extension, I got an error and I can't download the file.

[2020-07-01 12:49:13.801] [ERROR] console - (node:1) UnhandledPromiseRejectionWarning: convertFailed
(Use `node --trace-warnings ...` to show where the warning was created)
[2020-07-01 12:49:13.802] [ERROR] console - (node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
[2020-07-01 12:49:13.802] [ERROR] console - (node:1) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

If i don't set any font in the pad, the export work as expected.

I am using Etherpad version 1.8.4 and when testing this problem, I only install this extension with abiword.
I run the application with docker on a custom image which is very similar as the official one.

Can you have a look on this ? I really would like to use this extension on our production server.

It would be great and more useful to display a Button Icon in the Button bar instead of the Text which clutters the "Button" Bar. A click on the Button could open up the Menu so people can choose from it. The chosen format could get highlighted as replacing it with a long text would crash the Button bar completely.

By Hover or longer Tapping with the finger (on tablet/phone), the actual chosen value could be shown in the title tag.

Hi John,
I setup Etherpad for the first time yesterday and used your font_family plugin v0.3.1 without issue.
I rolled back my VM to make some database configuration changes and reinstalled your new 0.4.0 version this morning and now I cant change fonts. Can I ask you to verify this patch doesnt break something please?

Im using following git pull.

Version number: 1.8.4

Git sha: 6a0f73d

Installed plugins
ep_adminpads2
ep_etherpad-lite
ep_font_family

EDIT: Appears to affect only Chrome on my Mac.

buttons don't show up and getting a missing css

file

Could you please choose a license for this repo.

I upgraded to v0.3.0 and started seeing the following error:

[2020-05-08 13:58:07.604] [WARN] client - TypeError: $(...).val(...).niceSelect is not a function -- { errorId: 'nsqccRPaIh04HX8Dekte',
  msg: 'TypeError: $(...).val(...).niceSelect is not a function',
  url: 'https://example.com',
  linenumber: 5,
  userAgent: 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0' }

The plug-in seems to try to use translations for the font family names. However I doubt that these names should be translated.

Couldn't find translation key pad.settings.fontType.opendyslexic html10n.js:831:1
Couldn't find translation key pad.settings.fontType.comicsans html10n.js:831:1
Couldn't find translation key pad.settings.fontType.georgia html10n.js:831:1
Couldn't find translation key pad.settings.fontType.impact html10n.js:831:1
Couldn't find translation key pad.settings.fontType.lucida html10n.js:831:1
Couldn't find translation key pad.settings.fontType.lucidasans html10n.js:831:1
Couldn't find translation key pad.settings.fontType.palatino html10n.js:831:1
Couldn't find translation key pad.settings.fontType.tahoma html10n.js:831:1
Couldn't find translation key pad.settings.fontType.timesnewroman html10n.js:831:1
Couldn't find translation key pad.settings.fontType.trebuchet html10n.js:831:1
Couldn't find translation key pad.settings.fontType.verdana html10n.js:831:1
Couldn't find translation key pad.settings.fontType.symbol html10n.js:831:1
Couldn't find translation key pad.settings.fontType.webdings html10n.js:831:1
Couldn't find translation key pad.settings.fontType.wingdings html10n.js:831:1
Couldn't find translation key pad.settings.fontType.sansserif html10n.js:831:1
Couldn't find translation key pad.settings.fontType.serif

see ep_align for how i fixed this

I tried using getHTML to get the content of a pad and found the style information of font family is lost.

with chromium on Arch linux no problem,
whit firefox, changing font family does not change font family of selected text

[2024-04-23T19:20:19.335] [ERROR] settings - Error: /opt/etherpad-lite/node_modules/ep_etherpad-lite/templates/pad.html:70
    68|           <% e.begin_block("editbarMenuLeft"); %>
    69|           <%- toolbar.menu(settings.toolbar.left, isReadOnly, 'left', 'pad') %>
 >> 70|           <% e.end_block(); %>
    71|       </ul>
    72|       <ul class="menu_right" role="toolbar">
    73|           <% e.begin_block("editbarMenuRight"); %>

Cannot find module 'ep_font_family/templates/editbarButtons.ejs' from '/opt/etherpad-lite/node_modules/ep_etherpad-lite/templates'
    at Function.resolveSync [as sync] (/opt/etherpad-lite/node_modules/.pnpm/[email protected]/node_modules/resolve/lib/sync.js:111:15)
    at exports.require (/opt/etherpad-lite/src/node/eejs/index.ts:2:1579)
    at exports.eejsBlock_editbarMenuLeft [as hook_fn] (/opt/etherpad-lite/src/plugin_packages/ep_font_family/index.js:22:24)
    at callHookFnSync (/opt/etherpad-lite/src/static/js/pluginfw/hooks.js:122:16)
    at /opt/etherpad-lite/src/static/js/pluginfw/hooks.js:195:54
    at Array.map (<anonymous>)
    at exports.callAll (/opt/etherpad-lite/src/static/js/pluginfw/hooks.js:195:25)
    at exports.end_block (/opt/etherpad-lite/src/node/eejs/index.ts:2:1172)
    at eval ("/opt/etherpad-lite/node_modules/ep_etherpad-lite/templates/pad.html":72:10)
    at pad (/opt/etherpad-lite/node_modules/.pnpm/[email protected]/node_modules/ejs/lib/ejs.js:703:17)
    at exports.require (/opt/etherpad-lite/src/node/eejs/index.ts:2:2038)
    at /opt/etherpad-lite/src/node/hooks/express/specialpages.ts:2:1962
    at Layer.handle [as handle_request] (/opt/etherpad-lite/node_modules/.pnpm/[email protected]/node_modules/express/lib/router/layer.js:95:5)
    at next (/opt/etherpad-lite/node_modules/.pnpm/[email protected]/node_modules/express/lib/router/route.js:144:13)
    at Route.dispatch (/opt/etherpad-lite/node_modules/.pnpm/[email protected]/node_modules/express/lib/router/route.js:114:3)
    at Layer.handle [as handle_request] (/opt/etherpad-lite/node_modules/.pnpm/[email protected]/node_modules/express/lib/router/layer.js:95:5)
[2024-04-23T19:20:20.147] [DEBUG] http - 200, GET /health

Currently it provides an internal server error when loading with font family

How can I add other font-familys to it e.g. Microsoft YaHei even Chinese?

I don't get promp anywhere.

And Issues have no relevant questions~?

Font Families don't get listed in filemenu
font-colors get listed! perhaps check the differences.

If you select and area and change the font, and then move your cursor away from that area, the dropdown bar stays on that font name. It's misleading since it looks like you'd be typing in that font in the area you just clicked on.

etherpad-lite tag 1.8.14, ep_font_family from npm

When exporting a complete formatted file the given values do not get exported to .doc, .md, .odt, .pdf, etc.
Check issue ether/etherpad-lite#5211 as it is not clear if it is a problem with the core import/export functionality or a problem with the plugins that provide that information. The document inside etherpad gets actually properly formatted by those plugins!

That is the page that got exported! You can upload the NEW.ETHERPAD.txt file - remove (txt) before uploading.

Other export formats look as follow - on the same page:
Github doesn't like all formats so .txt got added and needs to get removed first.

• DOC - New.doc.txt
• ETHERPAD - New.etherpad.txt
• HTML - New.html.txt
• MD - New.md
• ODT - New.odt
• PDF - New.pdf
• TXT - New.txt