Comments (4)
Hmm interesting. So you're looking to pin the Eth Docker version while updating the clients.
I could do this with an .env
variable for the Eth Docker version - latest
or a specific tag. Let me think on it.
I haven't done semver because then I end up with version 112.x in rapid cadence 😅
from eth-docker.
Yeah I feel you 🤔 as an alternative to a semver, a commitSHA would also work. Although less user friendly, it would allow the same mechanism of being able to control which version of eth docker code base is being executed.
The command ethd update
could then simply print "eth docker updated to commit XYZ from commit ABC. To revert, run ethd update --version=ABC
".
Additionally, I'm also thinking: with your current defaults of pulling latest versions everywhere, if you go on vacation for 1-2 weeks and some clients meanwhile release breaking changes in their latest version, eth docker will be broken for everyone using those clients. So maybe you also want to print the clients version or commit sha as part of your script, to at least help debug issues (thinking out loud here)...
from eth-docker.
OK so as an MVP you can now pin the version of Eth Docker. That by necessity only works from v2.3.9 onwards, as otherwise it'll go to a version that has no idea what pinning is.
With the exception of Erigon, clients release breaking changes exceedingly seldomly. I'm OK with continuing the way it is ... if it ever becomes an issue I'll tackle it then. The last truly breaking change in a client was Nethermind and its binary location change. I don't expect they'll do that again.
Erigon - is Erigon. It comes with operational complexity that other clients don't have.
from eth-docker.
Sounds reasonable enough! Thanks for the great work 🚀
from eth-docker.
Related Issues (20)
- deleted
- "ETHD KEYS IMPORT" crashes my machine and I need to restart HOT 5
- Eth Docker does not know how to install Docker on linuxmint HOT 2
- config fail HOT 5
- Grafana 'Eth docker logs' dashboard broken on latest loki update HOT 1
- ERROR Invalid JWT: provided signature is invalid HOT 2
- Changing Withdrawal Credentials HOT 1
- ethd update reports error when two different checkouts use reth HOT 1
- metrics-exporter start script might not be useful
- Nethermind no longer auto pruning? HOT 3
- chown: invalid group HOT 1
- ./ethd resync-consensus eats up disk space HOT 1
- How to use self hosted web3signer instead of docker HOT 2
- Seems Sed fix on #1839 might have broken config for Linux HOT 1
- cadvisor started applying the 'latest' tag to their newest releases again HOT 1
- ethd keys import - sometimes not working - jq: error HOT 20
- Add risc-v support for eth-docker HOT 32
- Add Vouch as validator client option HOT 2
- ./ethd config error response from daemon HOT 3
- Add source-built Lambda
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eth-docker.