etf1 / restify-prom-bundle Goto Github PK

I wanted to make a PR to fix this, but it looks a little non-trivial and I was wondering to hear author's take on this.

I think that two metrics this library should expose would be http_request_duration_miliseconds and http_requests_total, with an option to disable path label.

@jucrouzet @ddalmais what do you think?

Hello,

When I call your lib as :

this._server.pre(promBundle.preMiddleware(this._server));

I've got this error :

A metric with the name restify_status_codes has already been registered.

Do you know how to resolve it ?

I comment in my code all healthz / metrics routes, it's change nothing..

The package.json specifies a peer dependency of Restify ~5. Is this still correct? I'm running Restify version 7 without any noticeable issues

I need that pull request from last year merged so I can use this

package.json versions
"restify": "^7.2.1",
"restify-prom-bundle": "^2.0.3",

using the default handler
server.pre(promBundle.preMiddleware(server, {/* options */}));

I get the following error:
TypeError: server.router.find is not a function
at ...\node_modules\restify-prom-bundle\built\js\preMiddleware.js:138:23