etchuk / etch.orchardcore.gallery Goto Github PK

Add support for customising alternate text.

The gallery content type doesn't have the Widget stereotype by default, and it probably should.

We don't really want a nested section in here (which is what the Model.Header creates, complete with a h1).

Suggested new default:

<h3 class="section__title">
    {{ Model.ContentItem.Content.TitlePart.Title }}
</h3>
{{ Model.Content | shape_render }}

Although I wonder whether we need the title in there or if we should encourage people to add that with the heading widget so they can set the appropriate heading level (likely to be 1, 2 or 3)

it doesn't work for video?

please give me an example for json media value, and how can i display in customize liguid page.

it posible to get media, directly from assest media module?

Add usage instructions that demonstrate what how the module works. We should also include details about https://sachinchoolur.github.io/lightgallery.js/ and state that while it's free and open source it does require a license for commercial use. We should include instructions on how you would switch out the front-end dependency on lightgallery for an alternative.

thanks for providing this module it works fine but when I try to widget with the gallery I can not add media

Currently no media in the gallery. see the image attached please advise what is required

note: gallery feature is enabled

Sorry... bit of a newbie problem probably.

I have tried both downloading your code and installing via NuGet. After adding into a site (based on The Agency Theme) using Orchard Core 1.4 and turning on the "Gallery" feature, I can see the Gallery Widget in Content Types. If I add it to a new Content Type and create an instance of that new Content type, I see the Add Media button but it does not do anything. AFter saving the new Content Item and then editing, the button still does not work.

Am I missing an obvious step?

Noticed when migrate content from one environment to another that all the images in the gallery were broken. This is because the image path includes the tenant URL prefix and media. When migrating this to another environment the tenant will likely have a different prefix.

The "Add Video Embed" module needs to have validation to check the input URL is a valid youtube/vimeo.

Creating this as a widget will allow the gallery to be rendered within flows as well, allowing users to render them anywhere on the page, not just forcing them into the footer.

Something to be aware of for this is that the Vue.js code is execting the "Add Media" button to be there on page load, so clicking this on one added dynamically without saving your content and reloading will give a non-working button.

Add a setting to the GalleryPart that can define the thumbnail size for images added via the media library. This is to avoid loading hi-res images before the user has interacted with the gallery.

From looking at this on @Newnab's machine, editing the settings on the part seems to save correctly, however, they don't seem to get passed back to the driver as it should, so we only ever get the default settings.

Currently, if you add the gallery to a new site it doesn't come with any styles besides the lightbox, while the gallery might be rendered differently across sites, it would be good to have a nice looking default rather than the browser's default ul/li styling

There is a dependancy security vulnerability which needs to be fixed.

Remediation
Upgrade tar to version 4.4.2 or later. For example:

"dependencies": {
"tar": ">=4.4.2"
}
or…
"devDependencies": {
"tar": ">=4.4.2"
}

More detail: https://nvd.nist.gov/vuln/detail/CVE-2018-20834

When exporting content parts, the gallery settings seem to be included when it's not related at all.

The Add Image URL module needs to have validation to check the input URL is a valid image.

i think you missd gallery style.

i can not find "list list--gallery js-gallery" style classes