etchuk / etch.orchardcore.contextualedit Goto Github PK

Just checked the error logs on a site running RC2 and spotted this warning:

The content part display driver 'Etch.OrchardCore.ContextualEdit.Drivers.ContextualEditPartDisplay' should not be registered in DI. Use UseDisplayDriver instead.

I've used your NuGet package in current version 1.4.0 in OrchardCore site and followed your instructions. Widget is displayed on homepage only.

So I downloaded your source code from github and referenced project to be able to debug.

The problem I've found is in the ContextualEditService, method GetContentItemForRequestAsync, line 42. The variable contentItemId is always null. And the reason is that _contentHandleProvider instance variable is AliasPartContentHandleProvider type instead of expected AutorouteHandleProvider type.

One solution that works for me is replace IContentHandleProvider with IContentHandleManager. It will use all content handle providers ordered by Order property and return first successfull result.

Another solution, that also works is to resolve AutorouteHandleProvider from content handle provider collection registered in dependency injection container. This solution will use only expected content handle provider. May there is another solution to resolve correct service from DI but currently I don't know how.

public ContextualEditService(IEnumerable<IContentHandleProvider> contentHandleProviders, IContentManager contentManager, IHttpContextAccessor httpContextAccessor, ISiteService siteService)
{
    _contentHandleProvider = contentHandleProviders.OfType<AutorouteHandleProvider>().First();
    _contentManager = contentManager;
    _httpContextAccessor = httpContextAccessor;
    _siteService = siteService;
}

Having a minimised state would be useful so as to not interfere so much with the page rendering.