The immutable-chunkmap from estokes

Add a way to remove multiple keys at once

Following the availability of insert/update many it would be nice to also have something like remove_many.
Alternatively (or also) retain function (like in btree map) could be added to support such (and other) use-cases, though that one traverses the whole tree, so it could be too costly if removed set of keys is much smaller than overall keys in the tree.

In my specific use-case I actually need to remove a range of keys, which I imagine might have a fast specialized implementation possible, but I suppose this could as well be a specific scenario possible to exploit in remove_many (as docs mention insert_many being faster on sorted entries).

And thanks for this lib, it looks pretty solid and performs very well!

Removing multiple keys for MapM with >= 1024 entries panics

I found a scenario of initializing map content and updating it (just removals) that causes panic, the repo scenario is here:
https://github.com/kskalski/snippets/blob/master/immutable_chunklist_bug/src/main.rs

roughly the code like that:

fn main() {
    let initial: Vec<(u64, _)> = vec![(695931000000, 344), ...];
    let mut update = vec! [(1933094000000, 0), ...];
    println!("init {:?}, update {:?}", initial.len(), update.len());
    let mut map = immutable_chunkmap::map::MapM::from_iter(initial.into_iter());
    map.update_many(update, |_, _, _| {
            None
    });
}

ends up with

     Running `target/debug/immutable_chunklist_bug`
init 1024, update 16
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/nazgul/.cargo/registry/src/github.com-1ecc6299db9ec823/immutable-chunkmap-1.0.4/src/avl.rs:672:53
stack backtrace:
   0: rust_begin_unwind
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/panicking.rs:142:14
   2: core::panicking::panic
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/panicking.rs:48:5
   3: core::option::Option<T>::unwrap
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/option.rs:775:21
   4: immutable_chunkmap::avl::Tree<K,V,_>::create
             at /home/nazgul/.cargo/registry/src/github.com-1ecc6299db9ec823/immutable-chunkmap-1.0.4/src/avl.rs:672:34
   5: immutable_chunkmap::avl::Tree<K,V,_>::update_chunk
             at /home/nazgul/.cargo/registry/src/github.com-1ecc6299db9ec823/immutable-chunkmap-1.0.4/src/avl.rs:792:17
   6: immutable_chunkmap::avl::Tree<K,V,_>::update_chunk
             at /home/nazgul/.cargo/registry/src/github.com-1ecc6299db9ec823/immutable-chunkmap-1.0.4/src/avl.rs:826:33
   7: immutable_chunkmap::avl::Tree<K,V,_>::update_chunk
             at /home/nazgul/.cargo/registry/src/github.com-1ecc6299db9ec823/immutable-chunkmap-1.0.4/src/avl.rs:826:33
   8: immutable_chunkmap::avl::Tree<K,V,_>::update_many
             at /home/nazgul/.cargo/registry/src/github.com-1ecc6299db9ec823/immutable-chunkmap-1.0.4/src/avl.rs:861:17
   9: immutable_chunkmap::map::Map<K,V,_>::update_many
             at /home/nazgul/.cargo/registry/src/github.com-1ecc6299db9ec823/immutable-chunkmap-1.0.4/src/map.rs:376:13
  10: immutable_chunklist_bug::main
             at ./src/main.rs:6:5
  11: core::ops::function::FnOnce::call_once
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/ops/function.rs:248:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

feeding it with any shorter initial set or update list or modifying the keys widely seem to no longer cause the panic.

estokes / immutable-chunkmap Goto Github PK

immutable-chunkmap's People

Contributors

Stargazers

Watchers

Forkers

immutable-chunkmap's Issues

Add a way to remove multiple keys at once

Removing multiple keys for MapM with >= 1024 entries panics

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent