esnvutbrno / fiesta-plus

New generation of social network for helping international students - used by sections of Erasmus Student Network. 💜 By volunteers, for volunteers.

Fiesta+

Fiesta is dead, long live Fiesta+!

New generation of social network for helping international students - used by sections of Erasmus Student Network. 💜 By volunteers, for volunteers.

Development

See the Development wiki page for more information.

Contributing

Use Pull requests -- how to prepare a great PR?

Authors

Created with love and maintained by @esnvutbrno members.

License

Distributed under the GNU GPLv3 License. See LICENSE.txt for more information.

fiesta-plus's Issues

Run pylint as GH Action

• currently, pre-commit hooks are used, but they are running without installed project dependencies
• that's not suitable for pylint, since pylint-django loads settings.py with all imports
• solution would be GH Action with installed deps and running pylint also with django module

old pre-commit hook:

- id: pylint
  name: Pylint with django plugin
  entry: poetry run pylint
  language: system
  exclude: "[a-zA-Z]*/(migrations)/(.)*"
  args: [
      "--load-plugins=pylint_django",
      "--django-settings-module=fiesta.settings",
  ]
  types: [ python ]
  require_serial: true

Image build caching

• currently cache towards image repository is disabled, since it ends with HTTP 400
• caching the build process is definitely needed, so would be nice to have i working
• TODO in deploy.yaml
• having standalone repository only for caching is also an option

Wiki Integration

• would be nice to have wiki integrated directly from Github
• https://github.com/github/markup

Flow

• Wiki stored in GH wiki
• Docker container fetches the GIT repository of Wiki
• Container with github/markup renders the content into HTML
• preprocessing? Redis?
• Django app to render the wiki on the page with Tailwind Prose
• searching! elasticsearch?

Type checked project (typing, mypy, GH Action)

• typing isn't currently an issue in django codebase
• would be nice to have type-checked python sources
• mypy works with pyproject.toml, so typing, mypy configuration and GH Action is needed
• to do:
  • django-stubs gonna be needed
  • probably some tweaks
  • integration to flake8

Visual bugs

• profile dropdown out of viewport on mobiles
• too long section name breaks header into two lines
• error pages are too big on mobiles
• my memberships hides section name on smallest mobiles
• footer not centred and without proper gaps
• empty menu on the main page weirdly jumps a few pixels on activation
• horizontal scroll on mobile tables
• dark mode for tom-select

Perms denied from buddy system dashboard

403 for click on dashboard buddy system "matching requests"

• enabled, but with policy not displayable?
• or dashboard doesnt respect privileged plugins?

OG metadata

• probably https://django-meta.readthedocs.io/en/latest/views.html with some root default configuration for meta and context manager passing it to all templates
• see https://www.vzhurudolu.cz/prirucka/meta-open-graph for tags

Can have either home faculty or home uni

Unable to save both home faculty and home university on profile update page

Works with just either faculty or uni

Automatic profile picture on ESNcard

Automatically add a profile picture to ESNcard during application from your profile picture at Fiesta
the only default value, possibility to change during the application

Suggested features from old Fiesta

Old Fiesta does have table for suggested features:

suggested feature	votes	planned?	note
Allow users to connect to Fiesta via Facebook.	30	✔️	#15
Let's turn this into an awesome app for our cell phones!	29	❓
Make messenger in Fiesta! It would be great, if we could contact foreign students directly through the Fiesta!	18	❓
I would like to see in profile of foreign student his/her buddy (assigned local member) - so I would know who is here assigned to help this person	16	✔️
Notifications (for example new event)	7	✔️
Search box in the header of a web	6	✔️
Make date of birth and country compulsary information during registration	6	✔️
Make the "Get your ESNcard" clickable and save it in their profile, so I don't have to make another form for people asking if they want ESNcard.	6	✔️
I would like to see in profile of local member his/her buddies (assigned foreign students) - so I would know which members are really active as a buddies	5	✔️
Some "All in one" page, including hyperlinks to KAM VUT, CESA (+registration), kolejnet, school pages and its faculties, our FB pages, DPMB, Brno maps and many others, could be added to the panel to better inform incoming Erasmus students to get familliar	4	✔️	probably part of section landing page
Let's use SSL in production :)	2	✔️
Include "Event Registration" (trips, parties, games) and "Event Overview" with calendar... :)	2	✔️
Change favicon to actual logo of fiesta	1	✔️
Add more phone numbers links to profile. There can be only one phone number the other one I hade to write in to link "About me"	1	✔️
dark theme/mode would be awesome	0	❓
Allow going back to the event manager from an event See registry status from event manager	0	✔️
It would be great to add the possibility of turning internationals to ESN member without the necessity of creating a new account (using the same email).	0	✔️
Please allow people to change their e-mail adress in the settings section. Also it would be nice to be able to delete the profile. Maybe include a "delete profile" button in the settings section. (I used the wrong email adress and now can not change it or	0	✔️
Add support for apple emoticons symbols.	0	✔️
How can I delete my fiesta account?	0	✔️
the option to delete profile/withdraw requests	0	✔️
Maybe create tags for the things that people like, so you can easily filter through people with the same interests as you	0	❓
See what semester student is doing erasmus - for example Winter 2021/2022	0	✔️

Techstack

proposals

• Docker containers
• Python 3.9
• Django 4.0
• DRF and/or Graphene-Django - API for mobile app/data export
• django-allauth - login by Facebook/Google
• audit -- audit data about changes
• django-lifecycle - to request changes notification etc.
• django-loginas
• django-admin-env-notice
• django-debug-toolbar
• django-mail-queue
• django-admin-reorder
• python-decouple - loading settings from env
• mypy, pre-commit, CI
• postgres ~ 14
• Tailwind ~ 3
• tailwindcss/forms?
• tailwindcss/typography?
• htmx? or?
• probably weback-based? parcel? or django-tailwind?

Plugin: Buddy&Pickup System

Buddy & Pickup System

Implemented as a plugin, both gonna be functionally pretty the same, so the codebase could share some parts. But still, needs to be implemented as two different Django apps.

Functionality

TBD

Plugin Configuration

The minimal configuration needed:

class BaseBuddyOrPickupConfiguration(BasePluginConfiguration):
    show_issuer_picture = BooleanField(default=False)
    show_issuer_gender = BooleanField(default=False)
    show_issuer_country = BooleanField(default=False)
    show_issuer_university = BooleanField(default=False)
    show_issuer_faculty = BooleanField(default=False)

    rolling_limit = PositiveSmallIntegerField(default=0)
    
    matching_policy = models.CharField(choices=...)

    class Meta:
        abstract = True


# https://en.wikipedia.org/wiki/Strategy_pattern
class MatchingPolicyProtocol(typing.Protocol):
    can_member_match: bool

    def limit_requests(
        qs: QuerySet['BaseRequest'],
        membership: SectionMembership
    ) -> QuerySet['BaseRequest']:
        ...

    def on_created_request(
        request: BaseRequest,
    ) -> None:
        ...

class ManualByEditorMatchingPolicy(MatchingPolicyProtocol):
    can_member_match = False

class ManualByMemberMatchingPolicy(MatchingPolicyProtocol):
    can_member_match = True

class SameFacultyMatchingPolicy(MatchingPolicyProtocol):
    ...

class LimitedSameFacultyMatchingPolicy(MatchingPolicyProtocol):
    ...
    # same faculty for N buddies
    # after N matches (to rolling_limit), faculty is not limited

class AutoMatchingPolicy(MatchingPolicyProtocol):
    ...
    # by internationals' selected interests
    # request will be matched to one from buddies automatically
    # (or the 'match' will be proposed to editor to confirm it)

Battleplan

• generate plugins (apps, but with django-admin startplugin) for buddy_system and pickup_system
• buddy could be the parent one (all needed there is subset of pickup)
• define models for configuration ☝️ (pickup configuration should cover the preferred limitation for where field)
• models for requests (state, FK issuer, FK related_section, matched_at, ...), probably with polyphormic as BaseRequest(Polymorphic) (all shared fields) -> BuddyRequest (empty) , PickupRequest (where, when)
• make forms for submitting requests
• make views to show all pending requests (respecting plugin configuration)
• make dashboard view to show that request has been placed (incl. how many students is waiting)
• define models for match (FK request, state, FK matched_by)
• make view to show member all matches

Audit system

• take https://github.com/spseol/project-thesaurus/tree/master/django/apps/audit + https://github.com/spseol/project-thesaurus/blob/master/django/apps/api/views/audit.py#L20
• do an integration to Fiesta
• to be discussed:
  • DRF or direct render?
  • permissions
  • tight bound to section?
  • storage/retention?

Authentication with social accounts

Authentication with social accounts

• at least with Facebook and Google, maybe Instagram, Twitter? all providers
• find out OAuth2 with ESN Accounts #28 #27
• django-allauth included into project, but definitely needs a lot of tweaks
• would be nice to have a defined ESN section domain, so login in with [email protected] leads directly to concrete ESN section (editor role?)

Providers

Facebook

Google

Empty page for BS root url when international

as international

Before First Deployment

• fancy 404, 403, 500
• error logs
• media & static files proper handling (whitenoise?)
• #221
• k8s?
• docker-compose.prod.yml
• https://lincolnloop.com/insights/go-live-production-checklist/

Unify social icon templates and styles

• social icons should have exactly one place of definition of colors/rounding/etc
• currently is on multiple places on project
• target is to have exactly one definition of templates and styles of all colors, borders and states for social icons
• templates should have option to include custom text

Pull request preview deployment

• would be nice to have possibility deploy fiesta directly from pull requests
• the target domain will follow the branch name
• only MR with specific MR will be deployed
• removing that label would uninstall the installation
• DB would use another schema
• target deployment namespace would follow the PR branch name

Plugin: Dashboard

Dashboard

Section's editor should be able to edit and style section dashboard (= first-page user sees after proper login).

Functionality

TBD

Techstack

• explore wagtail and its partial integration into Django projects
• https://gridstackjs.com/ with Alpine

Django Authenticator compatible with Nette\Passwords

Old Fiesta uses Nette\Security\Passwords for hashing/verifying passwords (leads to password_hash/password_verify with enabled bcrypt)

It's needed to reimplement it as Django Authenticator.

PoC:

#!/bin/env php
<?php
$pass = 'mypassword';

$hash = password_hash($pass, PASSWORD_BCRYPT);

echo $hash . PHP_EOL;

library bcrypt

#!/bin/env python3
import bcrypt

hashed = bytes(input(), 'utf-8')

password = b'mypassword'

if bcrypt.checkpw(password, hashed):
    print('matching')
else:
    print('not matching')

Solution

• probably django.contrib.auth.hashers.BCryptSHA256PasswordHasher with some tweaks
• https://docs.djangoproject.com/en/4.0/topics/auth/passwords/#using-bcrypt-with-django

Profile status completeness on dashboard block

• currently, the percentage is static
• the value should follow the real completness of profile
• template
• be aware, UserProfileForm is dynamic form constructed from configurations of all sections, in which is specific user in membership
• so the solution would be:
  1. construct the form via UserProfileForm.for_user(user: User)
  2. fill the form with instance of user
  3. compute the percentage of filled and unfilled fields in the form (not all fields, some defining subset of them)
  4. map the value to the color and display it

Fix empty dashboard block for buddy system

• hide the My Buddies sub-block OR display CTA for buddy matching
• block template

Section admins management

ESN Accounts = EA

• president from EA = root admin
• root admin can promote another admins or demote them
• admin can demote other admins, but not root admin
• for president switch, new root admin is logged in and do switch of them by removing the old one

Missing breadcrumbs on password change page

• breadcrumbs are on all profile pages, but here is missing
• would need more of investigation, since the view is from allauth and fiesta breadcrumbs probably need some kind of view support
• html <title /> works from the same items as breadcrumbs, and the title works, so problem is only with displaying them

Iceland phone number validation

+354 and seven numbers is currently not valid

CSRF verification fail after ESN Accounts login (Safari)

• in all cases it's a mobile browser (and probably Safari)
• from the first view straight to login and click ESN Accounts
• CSFR cookie is not set, so the callback fails on verification

Revisit containers build process

• current solution builds sequentially webpack, django and proxy containers, which is slow
• would be nice to revisit the order and make the build parallel, at least from part of it
• current dependencies:
  • django depends on webpack with webpack-stats.json which contains data about compiled assets
  • proxy depends on webpack with compiled assets, since these are served by proxy
  • proxy depends on django with collectstatic result, since these are also served by proxy
• so the order is webpack, django, proxy
• would be nice to have it more straighforward without magics with artifacts in deploy.yaml
• maybe integration of Werf/similar tool would be the solution

Invalid Instagram DB field

Instagram username in table UserProfiles cannot be saved into DB probably because invalid regex check

WebpackBundleTracker with enabled SRI doesn't work with webpack-dev-server

• running dev server with BundleTracker({integrity: true, ...})
• files really don't exist at that time of access -- just stats JSON file
• called from https://github.com/django-webpack/webpack-bundle-tracker/blob/master/lib/index.js#L154

webpack_1      | yarn run v1.22.17
webpack_1      | warning package.json: License should be a valid SPDX license expression
webpack_1      | $ webpack-dev-server --config webpack.dev.config.js
webpack_1      | BUILD_DIR=/usr/src/build
webpack_1      | PUBLIC_PATH=https://webpack.localhost/static/
webpack_1      | <i> [webpack-dev-server] Project is running at:
webpack_1      | <i> [webpack-dev-server] Loopback: http://localhost:8003/
webpack_1      | <i> [webpack-dev-server] Content not from webpack is served from '/usr/src/app/public' directory
webpack_1      | <i> [webpack-dev-server] 404s will fallback to '/index.html'
webpack_1      | <e> [webpack-dev-middleware] Error: ENOENT: no such file or directory, open '/usr/src/build/main.24a34978.css'
webpack_1      | <e>     at Object.openSync (node:fs:585:3)
webpack_1      | <e>     at Object.readFileSync (node:fs:453:35)
webpack_1      | <e>     at getSource (/usr/src/app/node_modules/webpack-bundle-tracker/lib/index.js:29:13)
webpack_1      | <e>     at /usr/src/app/node_modules/webpack-bundle-tracker/lib/index.js:154:53
webpack_1      | <e>     at /usr/src/app/node_modules/lodash.foreach/index.js:221:11
webpack_1      | <e>     at baseForOwn (/usr/src/app/node_modules/lodash.foreach/index.js:153:20)
webpack_1      | <e>     at /usr/src/app/node_modules/lodash.foreach/index.js:190:14
webpack_1      | <e>     at forEach (/usr/src/app/node_modules/lodash.foreach/index.js:290:10)
webpack_1      | <e>     at BundleTrackerPlugin._handleDone (/usr/src/app/node_modules/webpack-bundle-tracker/lib/index.js:147:5)
webpack_1      | <e>     at Hook.eval [as callAsync] (eval at create (/usr/src/app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1) {
webpack_1      | <e>   errno: -2,
webpack_1      | <e>   syscall: 'open',
webpack_1      | <e>   code: 'ENOENT',
webpack_1      | <e>   path: '/usr/src/build/main.24a34978.css'
webpack_1      | <e> }

Size of profile picture in tables

To unify the dimensions of the profile picture for all members in the overview of members

User profile entry page

• currently, user profile page entry is empty
• based on the information in other tabs, decide what we want to include on the entry page
• registration date? some basic statistics?
• view and template

Plugins overview

Buena Fiesta gonna have plugins, when each section could set up which plugins (and in which configuration) they want to use.

Buddy System 🆗 #12

Buddies matching as we know it, international students write brief information about them and people from sections take them. Internationals s also fill their social network profiles, hobbies or interests.

Pickup System 🆗 #12

International students could ask for pickup from the place of arrival, so they fill place and time of arrival and section members can take them. Requests for pickup and buddy are joint and offered to members for taking them together.

ESNcard Orders 🔥 🆕 #7

System gonna support sections in evidence of ESNcard applications - international students could fill their application, upload passport pictures and observe the status of their application. Plugin gonna be able to generate bulk print materials to increase the efficiency of ESNcard making. Students who already have ESNcard could fill their card numbers into the system to get discounts.

Events ☝️ 🔥 🆕

Old Fiesta events module never really worked, did it? Buena Fiesta offers new events module including registration, integration with Google calendar, events notifications and participants exports.

Office Open Hours 🔥 🆕

Sections usually have an office with official open hours. This module can show them publicly on a pretty URL, directions to this office could be also filled (with address), so students can just click to Google/Apple map.

Checklists 🔥 🆕

Going on Erasmus isn't an easy thing, this module offers checklists for common situations during Erasmus: what to do before, after arrival, during mobility or what to fulfil after. Checklists are offered by Fiesta, but section can define their own.

Dashboard 🔥 🆕 #14

The entry point for the whole application -- really nice and really catchy! Conversion directly into buddy system, ESNcard or social profiles of sections. Video, photo album or anything amazing, what ESN sections creates and defines.

Webdesign

Something modern, light, in ESN colors. 😄

Inspiration

• https://tailwindcss.com/docs/installation
• https://coinmarketcap.com/cs/ (tables)
• https://laracasts.com/
• https://helpninja.com/

Resources

• components: Flowbite personal favorite
• components: Tailblocks second favorite
• components: Tailwind Components user-contributed components
• components: Daisy personaly, I do not like the design
• ESN Colors
• Headless UI
• background patterns + https://github.com/AndreaMinato/tailwind-heropatterns
• color scheme generator
• tailwind typography online

Fix text and layout of log in buttons

1. Both buttons on the log in form should be centered
2. As per https://grammarist.com/spelling/log-in-login/ the correct term for both these button should be "log in", not "login"

TODO

TODO

Active

• .github/workflows/deploy.yml:113 ends with 400
• .github/workflows/deploy.yml:113 ends with 400
• .github/workflows/deploy.yml:115 ends with 400
• .github/workflows/deploy.yml:60 ends with 400
• fiesta/apps/accounts/adapters.py:21 making usernames from first_name is kinda bleeh
• fiesta/apps/accounts/forms/profile.py:112 think about limiting the choices by country of section, in which is current membership
• fiesta/apps/accounts/forms/profile.py:27 what to do, when no specific configuration is found?
• fiesta/apps/accounts/forms/profile.py:57 show only related facultites & universities
• fiesta/apps/accounts/forms/profile_factory.py:54 what to do, when no specific configuration is found?
• fiesta/apps/accounts/forms/profile_factory.py:92 what to do, when no specific configuration is found?
• fiesta/apps/accounts/models/profile.py:139 #23
• fiesta/apps/accounts/models/profile.py:141 define formfield/widget to handle flagging
• fiesta/apps/accounts/templatetags/memberships.py:16 the next cannot blindly follow the source /path, because user probably does have
• fiesta/apps/buddy_system/templatetags/buddy_system.py:34 could be more then one?
• fiesta/apps/esnaccounts/provider.py:75 definitely not, user nationality != section assignment
• fiesta/apps/esnaccounts/provider.py:80 check all possible for ESN Accounts roles
• fiesta/apps/esnaccounts/provider.py:84 should be as AccountsConfiguration attribute, so section can select
• fiesta/apps/esncards/views/applications.py:48 do it properly
• fiesta/apps/esncards/views/applications.py:94 limit somehow?
• fiesta/apps/events/models/event.py:10 Maybe pre-registration, registration and paused registration for different field.
• fiesta/apps/events/models/event.py:137 hybrid registration, default user, only online (qr), offline registrations (counter, subtract from capacity)
• fiesta/apps/events/models/participant.py:60 problematika ověřování lidí (QR check-in)
• fiesta/apps/events/models/participant.py:9 do we need a state if we have an expiration date
• fiesta/apps/fiestaforms/widgets/models.py:69 filter state?
• fiesta/apps/fiestaforms/widgets/models.py:91 filter state?
• fiesta/apps/fiestarequests/forms/request.py:19 group field somehow and add group headings
• fiesta/apps/fiestarequests/forms/request.py:45 add save/load of contacts to/from user_profile
• fiesta/apps/fiestarequests/matching_policy.py:101 make it working
• fiesta/apps/fiestarequests/matching_policy.py:28 NotImplemented or base implementation?
• fiesta/apps/fiestarequests/tables/editor.py:86 fix attrs accessor
• fiesta/apps/fiestarequests/tables/editor.py:89 dynamic by section preferences
• fiesta/apps/fiestarequests/views/editor.py:109 django.lifecycle would be probably better
• fiesta/apps/fiestatables/columns.py:15 probably not needed anymore
• fiesta/apps/files/storage.py:88 think about defining public url of bucket directly to nginx proxypass conf
• fiesta/apps/pages/models/page.py:77 probably not needed
• fiesta/apps/pages/urls.py:9 use custom converter https://docs.djangoproject.com/en/4.1/topics/http/urls/#registering-custom-path-converters
• fiesta/apps/pickup_system/urls.py:37 the url name is defined also in issuer/matcher_picture_url, better would be to generalize it
• fiesta/apps/plugins/admin.py:65 relating to django-polymorphic docs, UUID PK should not work
• fiesta/apps/plugins/middleware/plugin.py:60 check, if plugin is enabled, perms and all the stuff
• fiesta/apps/plugins/utils.py:40 resolver.app_name is full-dotted path
• fiesta/apps/sections/admin.py:41 Listing all memberships in section admin
• fiesta/apps/sections/forms/membership.py:15 preselect active?
• fiesta/apps/sections/models/membership.py:36 think about
• fiesta/apps/sections/models/membership.py:53 add flag to signalize, if membership has been added from ESN Accounts
• fiesta/apps/sections/models/membership.py:64 rename BANNED and add "PAUSED"
• fiesta/apps/sections/models/section.py:32 remove blankness after proper migration from ESN accounts
• fiesta/apps/sections/models/section.py:99 refactor to share code from CheckEnabledPluginsViewMixin
• fiesta/apps/sections/services/sections_plugins_validator.py:34 would be better to refactor to some kind of matrix:
• fiesta/apps/sections/tables/faculties.py:14 probably extract to constant in fiestatables
• fiesta/apps/sections/tables/internationals.py:21 do it properly
• fiesta/apps/sections/tables/internationals.py:21 do it properly
• fiesta/apps/sections/tables/members.py:21 do it properly
• fiesta/apps/sections/tables/membership_filter.py:40 needed?
• fiesta/apps/sections/tables/membership_filter.py:51 find out why search vector is not enough to find "Gus Fring" for "Fri"
• fiesta/apps/sections/urls.py:31 homepage for esn section plugin?
• fiesta/apps/sections/views/choose_space.py:22 temporary hack, have to decide if need to have choosespace page
• fiesta/apps/sections/views/choose_space.py:43 limit to current membership
• fiesta/apps/sections/views/mixins/membership.py:11 maybe specific error page? idk
• fiesta/apps/sections/views/mixins/membership.py:24 fallback to superuser (w/message) only if test_membership fails?
• fiesta/apps/sections/views/mixins/membership.py:26 should not happen? is always True?
• fiesta/apps/sections/views/stats.py:35 weird, filtering via self.filters keeps lookup_expr as exact
• fiesta/apps/universities/models/university.py:18 logo? or color?
• fiesta/apps/utils/management/commands/loadlegacydata.py:167 state
• fiesta/apps/utils/templatetags/navigation.py:43 consider better way
• fiesta/apps/wiki/elastic.py:112 really here?
• fiesta/fiesta/settings/auth.py:19 check, which settings are needed
• fiesta/fiesta/settings/db.py:14 access to legacy db by standard user
• fiesta/fiesta/settings/db.py:23 pass from ENV
• fiesta/fiesta/settings/files.py:26 pass from env
• fiesta/fiesta/settings/logging.py:19 [%(request)s] is bullshit here, since it's wsgi request only
• fiesta/fiesta/settings/project.py:28 fill from environ
• fiesta/fiesta/settings/project.py:73 replace by CSP
• get-docker.sh:447 [thaJeztah] remove the $CHANNEL check once 22.06 and docker-buildx-plugin is published to the "stable" channel
• get-docker.sh:447 [thaJeztah] remove the $CHANNEL check once 22.06 and docker-buildx-plugin is published to the "stable" channel
• webpack/src/css/_Forms.css:279 needed after daysiui migration to v4, probably better would be to drop it
• webpack/src/css/_Tables.css:47 refactor pagination to btn-group
• webpack/src/css/main.css:26 make it fine
• webpack/tailwind.config.js:13 till the #188 is fixed
• webpack/webpack.prod.config.js:11 breaks integrity after deploy
• webpack/webpack.prod.config.js:19 for cache purpose would be better to tweak CORS to allow serving from topdomain on subdomains with SRI
• wiki/fetcher.rb:138 well, GH or self-hosted?

Done

• .github/workflows/deploy.yml:207 ends with 400
• .github/workflows/docker-build.yml:54 tag
• docker-compose.prod.yml:23 figure out before deployment, whereever/where should be certs stored
• fiesta/apps/accounts/forms/profile.py:29 what to do, when no specific configuration is found?
• fiesta/apps/accounts/forms/profile.py:36 check also Membership.state?
• fiesta/apps/accounts/forms/profile.py:50 what to do, when no specific configuration is found?
• fiesta/apps/accounts/forms/profile.py:63 what to do, when no specific configuration is found?
• fiesta/apps/accounts/forms/profile_finish.py:19 find generic way for configuration instance -> form setup
• fiesta/apps/accounts/models/profile.py:132 social network profiles
• fiesta/apps/accounts/models/profile.py:138 weird, basically it's exactly one of these
• fiesta/apps/accounts/models/profile.py:22 required by section configuration...
• fiesta/apps/accounts/models/profile.py:24 define relation to section, membership
• fiesta/apps/accounts/models/profile.py:24 define relation to section, membership, universities
• fiesta/apps/accounts/models/profile.py:57 profile picture
• fiesta/apps/accounts/models/profile.py:71 help, not description
• fiesta/apps/accounts/models/profile.py:99 phone, profiles
• fiesta/apps/accounts/templatetags/memberships.py:19 default homepage for section? since public on / is not available in section space
• fiesta/apps/accounts/templatetags/user_profile.py:26 compute based on accounts conf and profile state
• fiesta/apps/accounts/views/membership.py:11 limit role only to member/international
• fiesta/apps/accounts/views/membership.py:11 clean role only to member/international
• fiesta/apps/accounts/views/profile.py:47 next?
• fiesta/apps/accounts/views/profile.py:48 mixin?
• fiesta/apps/buddy_system/admin.py:10 parent admin doesn't work with inserted middle abstract class BaseRequestSystemConfiguration
• fiesta/apps/buddy_system/forms.py:14 add notes, interests, etc
• fiesta/apps/buddy_system/forms.py:15 and others by preference of responsible_section
• fiesta/apps/buddy_system/forms.py:24 group field somehow and add group headings
• fiesta/apps/buddy_system/forms.py:64 add save/load of contacts to/from user_profile
• fiesta/apps/buddy_system/models/configuration.py:20 pass configuration?
• fiesta/apps/buddy_system/views/editor.py:101 fix attrs accessor
• fiesta/apps/buddy_system/views/editor.py:107 dynamic by section preferences
• fiesta/apps/buddy_system/views/matching.py:69 check matcher relation to responsible section
• fiesta/apps/buddy_system/views/matching.py:70 reset any previous match for this BR
• fiesta/apps/buddy_system/views/matching.py:78 target URL?
• fiesta/apps/buddy_system/views/request.py:33 depends, if member or international is here
• fiesta/apps/buddy_system/views/request.py:34 check existence of in_space_of_section, since without section it doesn't make sense
• fiesta/apps/dashboard/views/index.py:37 only by state? maybe the R/O or editor is needed
• fiesta/apps/esnaccounts/provider.py:63 check all possible for ESN Accounts roles
• fiesta/apps/esncards/templatetags/esncards.py:12 could be more then one?
• fiesta/apps/esncards/views/application.py:84 check perms
• fiesta/apps/fiestarequests/models/configuration.py:17 make it visible and working
• fiesta/apps/fiestarequests/models/configuration.py:25 pass configuration?
• fiesta/apps/fiestarequests/models/managers/request.py:20 check matcher relation to responsible section?
• fiesta/apps/fiestarequests/views/matching.py:31 check matcher relation to responsible section
• fiesta/apps/fiestarequests/views/matching.py:32 reset any previous match for this BR
• fiesta/apps/fiestarequests/views/matching.py:40 target URL?
• fiesta/apps/fiestatables/views/tables.py:20 get QS and rename the output
• fiesta/apps/pickup_system/forms.py:67 add save/load of contacts to/from user_profile
• fiesta/apps/pickup_system/templatetags/pickup_system.py:75 limit by semester / time
• fiesta/apps/plugins/admin.py:41 make configuration form field dependent on selected configuration
• fiesta/apps/plugins/middleware/plugin.py:32 not active membership, redirect or?
• fiesta/apps/plugins/middleware/plugin.py:38 resolver.app_name is full-dotted path
• fiesta/apps/plugins/middleware/plugin.py:44 decide, which section -> which plugin
• fiesta/apps/plugins/models/plugin.py:18 state with visibility only for editors and highers
• fiesta/apps/sections/middleware/section_space.py:30 check for existing section
• fiesta/apps/sections/middleware/section_space.py:31 detect active state of selected section
• fiesta/apps/sections/middleware/section_space.py:32 compare section space with active membership section
• fiesta/apps/sections/middleware/user_membership.py:22 Detect, in which membership is user logged:
• fiesta/apps/sections/middleware/user_membership.py:30 Detect, in which membership is user logged:
• fiesta/apps/sections/middleware/user_membership.py:36 check, if user does have a filled profile
• fiesta/apps/sections/models/section.py:108 what to do if user is logged and dashboard is not available?
• fiesta/apps/sections/views/members.py:20 do it properly
• fiesta/apps/sections/views/mixins/membership.py:11 maybe specific error page? idk
• fiesta/apps/sections/views/mixins/membership.py:12 maybe specific error page? idk
• fiesta/apps/sections/views/permissions.py:0 should not happen? is always True?
• fiesta/apps/sections/views/permissions.py:41 check anything else?
• fiesta/apps/utils/templatetags/breadcrumbs.py:34 eg "Home > Docs" doesn't make sense
• fiesta/apps/utils/templatetags/breadcrumbs.py:36 slash is not always the home page?
• fiesta/apps/utils/templatetags/navigation.py:38 define these urls elsewhere
• fiesta/fiesta/settings.py:0 check, which settings are needed & move to settings subpackage
• fiesta/fiesta/settings.py:117 access to legacy db by standard user
• fiesta/fiesta/settings.py:81 replace by CSP
• fiesta/fiesta/settings/auth.py:82 do redirect to special url with smart router, which redirects to section
• fiesta/fiesta/settings/security.py:10 set before deployment!
• fiesta/fiesta/settings/security.py:10 probably dynamic?
• get-docker.sh:0 [thaJeztah] remove the $CHANNEL check once 22.06 and docker-buildx-plugin is published to the "stable" channel
• get-docker.sh:447 [thaJeztah] remove the $CHANNEL check once 22.06 and docker-buildx-plugin is published to the "stable" channel
• webpack/tailwind.config.js:13 till the #188 is fixed
• wiki/fetcher.rb:67 does not work with relative paths

---

Generated by Github Action, please do not edit.
If you want to extract TODO into sub-issue, please include file:line somethere in the body text and add label todo.

Drop home_university for internationals

• currently too complex to have evidence of all universities (see #198)
• would be better to drop home university for all and have evidence only for subject of studies

User Profile Page

• my profile -- shows the current state of the profile + 'edit my profile' button

• change password -- shows Django form to change the password (or set in case of social account profile)

• social accounts -- shows a list of current connected social accounts and offers to connect new one or disconnect

• my stats -- TBD

• delete my account -- shows confirmation page about (soft-) deleting the profile

• help ("hotline")

• PandaCoins

• ??Notices

• menu component

• flex in tailwind

ESN Accounts & Sections Synchronisation

• would be nice to have authentication via ESN Accounts CAS
  • https://github.com/heddendorp/esn-speakers-list/blob/e4c3956b7942f8146ca19d3a43ee174755ad44d9/functions/index.js#L16
  • https://github.com/heddendorp/esn-speakers-list/blob/76a53ba9eec3956acf5cdb60c372a9e5ad427e2a/src/app/app.component.html#L16
  • https://accounts.esn.org/cas/login?service=https://fiesta.localhost/casTicket?dev=true
  • https://accounts.esn.org/cas/serviceValidate
  • used django-allauth-cas, logged extra-data:

{
  "mail": "[email protected]",
  "sc": "CZ-BRNO-VUT",
  "first": "Josef",
  "last": "Kolář",
  "nationality": "CZ",
  "roles": [
    "Local.activeMember",
    "Local.eventCoordinator",
    "Local.regularBoardMember"
  ],
  "extended_roles": [
    "Local.alumnus:LV-RIGA-ESN",
    "Local.activeMember:CZ-BRNO-VUT",
    "Local.eventCoordinator:CZ-BRNO-VUT",
    "Local.regularBoardMember:CZ-BRNO-VUT"
  ],
  "picture": "https://accounts.esn.org/sites/default/files/avatars/2020-09/9f17b98072388c0eae4711192e776796ae8004e947a5b186f316bf0b06ec380b.jpg",
  "gender": "M",
  "section": "ESN VUT Brno",
  "country": "ESN Czech Republic",
  "uid": "thejoeejoee"
}

• some of the synchronisation from ESN sources is needed:
  • https://accounts.esn.org/api/v2/sections

   {
  "label": "ESN VUT Brno",
  "code": "CZ-BRNO-VUT",
  "website": "https://esnvutbrno.cz/",
  "country": "Czechia",
  "cc": "CZ",
  "state": "active",
  "address": {
    "street_address": "Kolejní 2906/4\r\n612 00\r\nBrno\r\nCzechia",
    "locality": "Brno",
    "postal_code": "612 00",
    "country": "Czechia"
  },
  "cities": [
    {
      "name": "Brno",
      "cc": "CZ"
    }
  ],
  "geolocation": {
    "lat": "49.2311847",
    "lng": "16.5736247",
    "lat_sin": 0.7573505844605075,
    "lat_cos": 0.6530084932199027,
    "lng_rad": 0.2892643200048574
  },
  "university_name": "Brno University of Technology",
  "university_website": "https://www.vutbr.cz/en/",
  "updated": "1639496271",
  "facebook": "https://www.facebook.com/esn.vut.brno/",
  "instagram": "https://www.instagram.com/esnvutbrno/",
  "twitter": "",
  "video": "https://www.youtube.com/watch?v=pMPFoxjdXOI",
  "logo": "/sites/default/files/logos/CZ-BRNO-VUT.png"
}

• https://accounts.esn.org/api/v2/countries

  {
    "label": "ESN Czech Republic",
    "website": "https://www.esncz.org/",
    "cc": "CZ",
    "country": "Czechia",
    "address": {
      "street_address": "Žerotínovo náměstí 9\r\n601 77\r\nBrno\r\nCzechia",
      "locality": "Brno",
      "postal_code": "601 77",
      "country": "Czechia"
    },
    "updated": "1638545216",
    "facebook": "https://www.facebook.com/esncz",
    "instagram": "https://www.instagram.com/esn_cz/",
    "twitter": "https://twitter.com/esn_cz?s=20",
    "video": "",
    "logo": "/sites/default/files/logos/CZ.png"
  }

Changelog creation

Add action that would run after merging PR into develop to create changelog. Use comitizen or google's release-please.

Table filters doesn't work for substrings

Search member based on substring of name (or help during writing name)

Migration process

New Buena Fiesta without old data would be total BS, so that's why.

• legacy schema database as .sql
• database scanned by Django inspectdb
• universities database

Battleplan

• new model definition
• Django command to migrate from the legacy database
• use raw Django cursor to legacy database
• custom Database router to have legacy db read-only
• use some kind of service layer to parameterize migration (static/dynamic data)
• rehash user passwords? #1
• limit migrated models? (data_user does have 11k rows currently)
• profit 💸

Tailwind content scanning in Python files

Including python files in Tailwind content scanning paths ends with permission denied:

TAILWIND_CONTENT_PATH="/usr/src/fiesta/**/*.py"

buena-fiesta-webpack-1      | ERROR in ./src/css/main.css (./src/css/main.css.webpack[javascript/auto]!=!./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[2].use[2]!./src/css/main.css)
buena-fiesta-webpack-1      | Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
buena-fiesta-webpack-1      | Error: EPERM: operation not permitted, open '/usr/src/fiesta/apps/sections/forms/plugin_configuration.py'
buena-fiesta-webpack-1      |  @ ./src/css/main.css
buena-fiesta-webpack-1      |  @ ./src/main.js 1:0-24
buena-fiesta-webpack-1      |
buena-fiesta-webpack-1      | ERROR in ./src/css/main.css
buena-fiesta-webpack-1      | Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
buena-fiesta-webpack-1      | HookWebpackError: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
buena-fiesta-webpack-1      | Error: EPERM: operation not permitted, open '/usr/src/fiesta/apps/sections/forms/plugin_configuration.py'
buena-fiesta-webpack-1      |     at tryRunOrWebpackError (/usr/src/app/node_modules/webpack/lib/HookWebpackError.js:88:9)
buena-fiesta-webpack-1      |     at __webpack_require_module__ (/usr/src/app/node_modules/webpack/lib/Compilation.js:5067:12)
buena-fiesta-webpack-1      |     at __webpack_require__ (/usr/src/app/node_modules/webpack/lib/Compilation.js:5024:18)
buena-fiesta-webpack-1      |     at /usr/src/app/node_modules/webpack/lib/Compilation.js:5095:20
buena-fiesta-webpack-1      |     at symbolIterator (/usr/src/app/node_modules/neo-async/async.js:3485:9)
buena-fiesta-webpack-1      |     at done (/usr/src/app/node_modules/neo-async/async.js:3527:9)
buena-fiesta-webpack-1      |     at Hook.eval [as callAsync] (eval at create (/usr/src/app/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
buena-fiesta-webpack-1      |     at /usr/src/app/node_modules/webpack/lib/Compilation.js:5002:43
buena-fiesta-webpack-1      |     at symbolIterator (/usr/src/app/node_modules/neo-async/async.js:3482:9)
buena-fiesta-webpack-1      |     at timesSync (/usr/src/app/node_modules/neo-async/async.js:2297:7)
buena-fiesta-webpack-1      | -- inner error --
buena-fiesta-webpack-1      | Error: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
buena-fiesta-webpack-1      | Error: EPERM: operation not permitted, open '/usr/src/fiesta/apps/sections/forms/plugin_configuration.py'
buena-fiesta-webpack-1      |     at Object.<anonymous> (/usr/src/app/node_modules/css-loader/dist/cjs.js!/usr/src/app/node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[2].use[2]!/usr/src/app/src/css/main.css:1:7)
buena-fiesta-webpack-1      |     at /usr/src/app/node_modules/webpack/lib/javascript/JavascriptModulesPlugin.js:452:10
buena-fiesta-webpack-1      |     at Hook.eval [as call] (eval at create (/usr/src/app/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:7:1)
buena-fiesta-webpack-1      |     at /usr/src/app/node_modules/webpack/lib/Compilation.js:5069:39
buena-fiesta-webpack-1      |     at tryRunOrWebpackError (/usr/src/app/node_modules/webpack/lib/HookWebpackError.js:83:7)
buena-fiesta-webpack-1      |     at __webpack_require_module__ (/usr/src/app/node_modules/webpack/lib/Compilation.js:5067:12)
buena-fiesta-webpack-1      |     at __webpack_require__ (/usr/src/app/node_modules/webpack/lib/Compilation.js:5024:18)
buena-fiesta-webpack-1      |     at /usr/src/app/node_modules/webpack/lib/Compilation.js:5095:20
buena-fiesta-webpack-1      |     at symbolIterator (/usr/src/app/node_modules/neo-async/async.js:3485:9)
buena-fiesta-webpack-1      |     at done (/usr/src/app/node_modules/neo-async/async.js:3527:9)
buena-fiesta-webpack-1      |
buena-fiesta-webpack-1      | Generated code for /usr/src/app/node_modules/css-loader/dist/cjs.js!/usr/src/app/node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[2].use[2]!/usr/src/app/src/css/main.css
buena-fiesta-webpack-1      | 1 | throw new Error("Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):\nError: EPERM: operation not permitted, open '/usr/src/fiesta/apps/sections/forms/plugin_configuration.py'");
buena-fiesta-webpack-1      |  @ ./src/main.js 1:0-24
buena-fiesta-webpack-1      |
buena-fiesta-webpack-1      | ERROR in webpack/runtime/hot module replacement
buena-fiesta-webpack-1      | EPERM: operation not permitted, open '/usr/src/app/node_modules/webpack/lib/hmr/HotModuleReplacement.runtime.js'
buena-fiesta-webpack-1      |
buena-fiesta-webpack-1      | ERROR in webpack/runtime/hot module replacement
buena-fiesta-webpack-1      | EPERM: operation not permitted, open '/usr/src/app/node_modules/webpack/lib/hmr/HotModuleReplacement.runtime.js'
buena-fiesta-webpack-1      |
buena-fiesta-webpack-1      | ERROR in webpack/runtime/jsonp chunk loading
buena-fiesta-webpack-1      | EPERM: operation not permitted, open '/usr/src/app/node_modules/webpack/lib/hmr/JavascriptHotModuleReplacement.runtime.js'
buena-fiesta-webpack-1      |
buena-fiesta-webpack-1      | 3 errors have detailed information that is not shown.
buena-fiesta-webpack-1      | Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.
buena-fiesta-webpack-1      |
buena-fiesta-webpack-1      | webpack 5.88.2 compiled with 5 errors in 4451 ms

HTML files during the same build completes successfully and Tailwind successfully scans thems. Even solution with manual globing fails, so the problem is not in the glob, but in the loading the py files through webpack loaders.

[How To] Populate DB with test/dummy data

I am building the project locally to test out the project and wanted to know how I can populate the database with dummy values. The place I am facing issue while completing my profile locally and the Universities and Faculty cannot be selected since there are no options to select from. Hence, I would like to know how I can pre-fill the database with test data. I have followed the instructions on the README.md file before starting the development server.

Colored avatar ring for roles

• mainly for easier debugging received screenshots
• small color ring around avatar to distinguish between member/editor/admin
• probably gray for members, primary for editors and secondary for admins
• activated for current membership role, outside of section space without ring

Notifications: what, how, when?

Notifications

• when?
• how? push? emails? telegram bot?
• how?

TODO: push notifications & emails

Plugin: ESNcard Applications

ESNcard Orders

Application Form

• system gonna already have enough information about the student
• ESNcard needs to have (already known data 👤, application form ✏️)
  • first and last name 👤
  • nationality 👤
  • date of birth ❓
  • studies at 👤
  • ESN Section 👤
  • valid since - application/export/issue date
  • photo of owner ✏️
• model stores passport-sized photo and copy of all needed data from user profile

Photo Processing

• photo needs to be cropped (and improved) to passport size (ESNcard does have space for 27x37mm photo)
• dlib or opencv? SO solution

Data Export

• for sections without interest in exporting print materials
• probably CSV/Ex*el of card applications

Export Print Materials

• based on a selected set of students, the plugin is able to render PDF files with
  • photos&labels - for debugging reasons
  • photos sized to ESNcard with a small label
  • labels sized to ESNcard -- used for printing on transparent foil
• ESNcard materials PDF Generator

Battleplan:

• plugin initialization and application form done in #26

Misc

• card scanner? - barcode specs
• validation endpoint: https://esncard.org/services/1.0/card.json?code=...

Invalid Faculty/University check

In profile both home university and home faculty can not be added.

Use cases

Terminology

• member is regular member of ESN section
• editor is coordinator/supporter responsible for ESNcards/buddy system
• admin is responsible (board) member of ESN section
• international is international student as client of this system
• plugin is a part of Fiesta responsible for one section agenda (buddy/pickup system, events, ESNcards, etc.)

User

• can sign up by email&password
• can sign up with Facebook, Google; Instagram? ESN Accounts?
• does have confirmed email
• does have roles in different ESN sections
• can edit his profile, upload profile image, fill social network profiles, Telegram account
• can delete his profile
• can change his password
• can control notifications (email/Telegram/Push?)
• can export/connect events calendar of his section

International ⊆ User

• can create buddy/pickup request (if enabled)
• is notified of his fulfilled request
• can see his matched buddy/pickup and write him
• can apply for ESNcard by filling in needed info (if enabled)
• can see events of his section and apply for them (if enabled)

Member ⊆ User

• can see buddy/pickup requests and match them
• can see his history of buddies

Editor ⊆ Member

• can manually match buddy/pickup requests
• can see ESNcard applications and generate print materials from them
• can mark ESNcard application as issued
• can create and edit events and see details/statistics about them
• can approve memberships to his section
• can edit all static pages of his section

Admin ⊆ Editor

• can edit details of all users in his section
• can transfer international/member to another section
• can create membership for his section
• can configure plugins in his sections
• can manage membership roles in his section

Limit displayed social account providers

• currently, the list of providers on login/sign up page is static and not rendered dynamically
• has to be rendered dynamically same as it is on profile social accounts
• ideally the icons/buttons are standalone templates, which could be used in the profile page>social accounts, so the design is matching
• use allauth templatetags to load the providers:

{% load socialaccount %}
{% get_providers as socialaccount_providers %}

• I'd keep the ESN accounts bigger, but that's for discussion definitely

Matched buddies are not showed

BUDDY block is empty even though I just matched with a buddy