eser / immunity Goto Github PK

pick method

immunity.pickFromObject({ a: 1, b: 2, c: 3 }, 'a', 'c') == { a: 1, c: 3 }

Lerna is currently release candidate for version 2.0. As soon as they published 2.0, looking possibilities of managing npm packages with Lerna would be useful.

Hey !

• Node version : v9.7.1
• npm version : 5.6.0
• ponyfills version : 0.8.4
• create-react-app version : v1.1.1

When running npm run build :

Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file: 

 	./node_modules/ponyfills/lib/assign.js:3 

Read more here: http://bit.ly/2tRViJ9

This leads to facebook/create-react-app/.../README.md#npm-run-build-fails-to-minify which tell us :

npm run build fails to minify

Some third-party packages don't compile their code to ES5 before publishing to npm. This often causes problems in the ecosystem because neither browsers (except for most modern versions) nor some tools currently support all ES6 features. We recommend to publish code on npm as ES5 at least for a few more years.

To resolve this:

1. Open an issue on the dependency's issue tracker and ask that the package be published pre-compiled.

• Note: Create React App can consume both CommonJS and ES modules. For Node.js compatibility, it is recommended that the main entry point is CommonJS. However, they can optionally provide an ES module entry point with the module field in package.json. Note that even if a library provides an ES Modules version, it should still precompile other ES6 features to ES5 if it intends to support older browsers.

2. Fork the package and publish a corrected version yourself.

3. If the dependency is small enough, copy it to your src/ folder and treat it as application code.

In the future, we might start automatically compiling incompatible third-party modules, but it is not currently supported. This approach would also slow down the production builds.

I think the best solution is to precompile to ES5, and btw avoid any compatibility issue.