Coder Social home page Coder Social logo

Add Gaussian quadrature methods about torchquad HOT 4 CLOSED

esa avatar esa commented on July 23, 2024
Add Gaussian quadrature methods

from torchquad.

Comments (4)

elastufka avatar elastufka commented on July 23, 2024

Hello, I'm interested in a Torch implementation of Gauss-Legendre quadrature. The code here seems clear enough so I'll see what I can do based on the examples of the existing integrators.

If you have any thoughts on potential pitfalls in such an implementation, or just remarks on things to look out for in general, I'd appreciate it! Or if you know of someone who's already started work on this, even better.

from torchquad.

gomezzz avatar gomezzz commented on July 23, 2024

@elastufka Great to hear! I would suggest to branch out from #137 because this introduces quite some changes in the codebase (and by following the other integrators there your implementation will also support torch, TF, jax and numpy :) )

We'll be merging #137 shortly. Nobody has started work on this to my knowledge. If you want more feedback on implementing feel free to post some thoughts where you want to add things etc.

Thanks!

from torchquad.

elastufka avatar elastufka commented on July 23, 2024

@gomezzz Okay, I will do that.

So far everything seems pretty straightforward. One thing that wasn't quite clear from the documentation/code - are the inputs x to the integrals preferentially tensors, or numpy arrays?

from torchquad.

gomezzz avatar gomezzz commented on July 23, 2024

One thing that wasn't quite clear from the documentation/code - are the inputs x to the integrals preferentially tensors, or numpy arrays?

Well the integrand function is user-defined, so inside the user could convert (will break gradient flow though). Internally, torchquad will in the new version generate the data type matching the framework. so torch.tensor , np.array etc.

There are new examples in the docs to illustrate how it works with other frameworks

Making it cross-framework compatible with autoray is very similar to just writing torch. Have a look here, e.g. https://github.com/FHof/torchquad/blob/develop/torchquad/integration/boole.py

Basically you just use anp.sum(...) instead of torch.sum(...) and from autoray import numpy as anp

from torchquad.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.