Comments (4)
It fails in _check_integration_domain
, which validates that the user has passed a valid integration domain.
Checking that the domain has a positive size in each dimension does not work with trace compilation, so the check is disabled in this case.
To determine if the code is currently compiled, the type of boundaries_are_invalid
is investigated; if it is (before TensorFlow 2.14.0) tf.Tensor and not tf.Variable or something different, the code is currently being compiled.
If I remember correctly, I have implemented it this way because I could not find a clean way to check if the code is currently being compiled or not.
According to the CI log, the test has worked with TensorFlow 2.13.1 and now it fails with TensorFlow 2.14.0.
It fails now because with a recent TensorFlow version, the type is tf.SymbolicTensor and not tf.Tensor.
This breaking change is mentioned in TensorFlow's release notes.
I suggest to abstract away the check if code is currently compiled into a helper function.
For the TensorFlow backend, the function could use tf.is_symbolic_tensor
for TensorFlow >= 2.13.0 and the check if the type is tf.Tensor for older TensorFlow versions.
from torchquad.
I have implemented the helper function in #197
from torchquad.
Thank you for the help! I appreciate it. Would probably take me forever to understand the cross-module wizardry that is happening now :D
from torchquad.
No problem.
from torchquad.
Related Issues (20)
- Change behavior of 'backend' HOT 6
- Elementwise numerical integration HOT 28
- Let user choose which GPU to use HOT 4
- torch dataloader crashed after `set_up_backend` HOT 4
- Cannot import torchquad (conda install) HOT 2
- A lot of warnings in the current test CI on develop HOT 1
- Add tests for JIT HOT 2
- Evaluate many different integrands over the different domain HOT 6
- Coverage check fails on PRs HOT 1
- Release 0.4.0 HOT 8
- Tests failing on GPU HOT 15
- torch.tensor containing integers as integration domain returns zero with non-compiled integrator HOT 2
- Logging with loguru not implemented correctly
- Example/documentation for parametric domain of integration? HOT 9
- Integrate function with parameters HOT 3
- Google Colab TPU support HOT 8
- CI failing on coverage check
- depricated torch.set_default_tensor_type()
- torchquad0.4版本没有BatchMulVEGAS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from torchquad.