ervandew / ag Goto Github PK

I would like to use the --smart-case option by default, and it would be useful if the ag plugin had an option for this.

Maybe it's even a good idea to enable this option by default?

There is the following code in plugin/ag.vim:

if exists('*setqftitle')
  call setqftitle('ag' . args)
endif

I wondered where it might come from, and then found a mailing list thread about it:
https://groups.google.com/d/msg/eclim-dev/_FGmSoZ24ak/Bl1Jc1eFI1QJ

It still applies (except for the syntax hunk).

Is this still the latest patch?
Have you proposed it for inclusion in Vim?

btw, there's a warning when building:

eval.c: In function ‘f_getqftitle’:
eval.c:11784:26: warning: assignment makes pointer from integer without a cast [enabled by default]
     rettv->vval.v_string = get_errortitle(wp);
                          ^

It would be useful to have :Ag! not go to the first search result, but just let it do the search and probably automatically open the quickfix window then.

:Ag 'foo' should behave like :Ag foo.

The current logic appears to be that quotes are taking literally, if there is not space in them.

Is this on purpose?

There is ack.vim [1], which can be easily used with "ag", too.
There is ag.vim [2], a fork of ack.vim, defaulting to "ag".

And there is "ag", which I just discovered.

ack.vim/ag.vim provides a lot of mappings for the quickfix window for handling the results (https://github.com/rking/ag.vim#keyboard-shortcuts) and provides different commands to manipulate the quickfix list (https://github.com/rking/ag.vim/blob/master/plugin/ag.vim).

While evandew/ag appears to be more sophisticated related to the invocation of "ag" (file filter, option completion, argument parsing, escaping, ...).

I am a long-time user of ack.vim, with ag as ackprg/grepprg, and primarily want to get opinions about merging features/functionality of both.

/cc @rking @mileszs

1: https://github.com/mileszs/ack.vim
2: https://github.com/rking/ag.vim
3: rking/ag.vim@mileszs:master...master

ERR: Error stat()ing: foo
ERR: Error opening directory foo: No such file or directory
ERR: Error stat()ing: bar"
ERR: Error opening directory bar": No such file or directory

The command being executed in this case is:

ag --search-files --column '"' 'foo' 'bar"'

It would be useful if the plugin would set the search register (@/) automatically after searching.

What do you think?
There should probably be an option for this (off by default)?

That would probably only require to use lexpr instead of cexpr and the same for copen/lopen etc.

There might be a global var to control this, and additional commands Agl and Agc/Agq to call a specific variant.

I am testing out tplugin, which allows to lazily load Vim plugins.

From the issue I reported:
Please consider to move the Complete function to autoload/ag.vim as ag#Complete, which would facilitate the use with tplugin.

I would be happy to create a PR for this - just let me know.