91tdd's People
91tdd's Issues
Review completed
Good job.
Some suggestions:
-
Although you declare List as readonly, the elements of List still can be modified. You should use structure like ReadonlyCollection.
-
Column as a string argument has some advantages and some constraints, as a first version of delivery, you did it very well. Try to fulfill the other flexibility requirements, like pass a lambda for choosing what columns client want to sum.
day 2 review completed
建議找機會重寫(或許是上課完)
-
第二個測試案例就把一堆紅燈補上去,然後硬幹了 production code (這個動作是沒意義的),導致瞬間產生一大堆不好維護的 production code, 連重構都不容易下手,幾乎只能重寫。這跟作業的規範也不符合。
-
最終的 production code 可讀性很差,你可以跟任何一個上課的同學交換一下想法,他們瞭解需求,但他們是否能不經過你解釋,就看懂、甚至維護你的程式碼。需求異動之後,是不是能輕易應付需求?
-
不該 public 的,就不要 public。命名可以再精準一點。
我不馬上給你 sample solution, 因為沒太大意義,只能說作法差異挺大的。
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.