ericfillion / cmpe-327

A course project where we created a ticket selling web application while following professional SWE standards.

Company/blog: https://www.vennify.ai/

YouTube: https://www.youtube.com/channel/UC7-EWrr8YdcQgPPk76OiUVw

Medium: https://medium.com/@ericfillion

LinkedIn: https://www.linkedin.com/in/ericfillion/

cmpe-327's Issues

Formatting error for frontend tests

As shown in the photo below, there needs to be an additional new line in the frontend-tests.md file. Assume that the file is called "frontend-tests.md" and not "frontend_tests.md" because we'll merge PR #26 first.

Error on test teardown relating to temp. DB

With the new temporary database file, we are getting some erroneous behaviour during test teardown.
The process cannot access the file because it is being used by another process: <DB file>

Cases already covered for buy test

Wouldn't the first three cases covered by the fourth case, as if the ticket exists it should meet those requirements. And even if somehow the ticket exists and doesn't meet those requirements, that shouldn't be a constraint when buying the ticket as you should be able to buy any of the tickets that are there.

Eric think you had a similar question about the password requirements when logging in.

R2 register: For any formatting errors, redirect back to /login and show message

https://github.com/EricFillion/CMPE-327/blob/master/qa327/frontend.py#L50-L53

GitHub Testing Actions

Hey, I'm trying to write the section about the testing framework for A1, and I had a few questions about the GitHub testing.
Does anyone know if the testing actions are set up on GitHub at the moment? I don't think they are, since otherwise it would be checking each pull request we submit, right?
To my understanding we're supposed to have automated testing on every change that goes into the codebase - is that right? If so I can set it up after A1 is done, I just have to know what to put in response to "[our team's] understandings of when and how the test cases will be running directly on GitHub".

Need to learn Flask?

I haven't try flask before, should we learn it for better testing?

Recommended practice: avoid raw sql

Hello. Not an actual bug but just a recommended practice to avoid future failure or code vulnerability:

avoid raw static SQL string/template as much as possible

CMPE-327/qa327_test/backend/test_get_user.py

Lines 44 to 45 in a6d8cb5

	sql = "DELETE FROM User WHERE email='[email protected]'"
	print(db.session.execute(sql))

CMPE-327/qa327_test/backend/test_get_user.py

Lines 32 to 33 in a6d8cb5

	sql = "DELETE FROM User WHERE email='[email protected]'"
	print(db.session.execute(sql))

Problem with the provided specifications

I found a problem with the specifications they gave us. According to R7, the /logout endpoint is only supposed to support the HTTP POST method. However, in the example testcases, the instructions state "Open /logout". Assuming that "opening" a page refers to navigating the web browser to that page, this will perform the HTTP GET method, which is unsupported by the /logout endpoint and should result in a 404 as per R8.

This is obviously not the intended behaviour. How should we deal with this discrepancy? Should we reach out to the teaching staff so they can revise the specifications?

Create a gitignore file

ignore:

1. pycache files.
2. ".idea/" folder