ericezam / godot-color-palette Goto Github PK

Hi. It seems that I cannot store colors with alpha values != 255.
I'm using a 3.x win version of Godot.

Love this addon! Any chance of a Godot 4 version of it now that the first beta version was just released?

I have got two palettes in a folder. I can visualize them in the "Color Palette" window of the plugin. However when I click on "Load into Picker", nothing happens. The palette I click on does not appears in the color picker. I tried to Reopen the scene but it did not solve the issue.

Steps to reproduce:

• Download this palette as a .gpl file https://lospec.com/palette-list/zughy-32.
• Click the reload palettes button

Observed behaviour: the palette is not imported and the following error appears on the console: res://addons/color-palette/PaletteImporter.gd:37 - Invalid get index '1' (on base: 'PoolStringArray').

Expected behaviour: the palette is correctly imported.

Hi,

I was trying to use this add-on with the following palette, generated with GIMP 2.10.18, but some colors were lost, not parsed correctly.

The issue seems to be with the test for lines that start with numbers.
Apparently, valid palette entries can start with whitespace.

See for instance:

GIMP Palette
Name: [famicube]
Columns: 16
#
  0   0   0	Index 0
224  60  40	Index 1
255 255 255	Index 2
215 215 215	Index 3
168 168 168	Index 4
123 123 123	Index 5
 52  52  52	Index 6
 21  21  21	Index 7
 13  32  48	Index 8
 65  93 102	Index 9

Notice also that after the entry there's a name (in this case it seems autogenerated, but perhaps you can manually fill them in?). It comes after a tab \t.

The format seems to be:

[spaces (optional)] R [spaces] G [spaces] B [tab] name

I made a fork of this repo, and created a fix which properly imports the .gpl file I had.

turbohz@15fcf7f

Would you like me to submit a pull request?

Cheers.