erasaur / kolmon Goto Github PK

Can organize models by using:

• a lib folder that exposes the model (and certain methods) to both client and server
• a client folder that extends the model with client-only methods
• a server folder that extends the model with server-only methods

This way, common logic can be reused on both client and server.

e.g for challenges, instead of clicking on the player's name in the sidebar, allow users to click on the player's icon.

constructors, cleanup methods, etc. are all very similar. should be able to subclass a "base" class and automatically have those methods defined in super.

i.e don't start the next move until we have arrived (or almost arrived) at destination. the idea is to follow the movement queue more strictly so we don't have sudden jumps in position (which I suspect might happen when the client time somehow gets out of sync and triggers a setPosition before the move actually finishes)

• account for closing the browser (should properly cleanup stale battle documents)
• account for idling -> kicked out of battle

Seems like it happens after multiple moves in quick succession (maybe this.move is never set to false?) and only for other users (i.e not ourselves)

http://pokeapi.co/

Not sure about the reliability/speed though. Might be better just to host the files on our own server and not have to worry about api changes, since they are not too large.

Have a Pokemon class as well as a Pokemon collection, both of which have the same name because the plural form has no 's'. Should probably move collections into KOL.collections and models into KOL.models or something similar to avoid conflicts in the future.

• disallow having no pokemon in team, assign first pokemon in team as "leader"
• implement catching pokemon (status effects, low hp, speed, etc.)
• implement leveling up pokemon/evolving
• handle adding newly caught pokemon to team if space allows, otherwise store in PC (can just represent PC as _.difference(user.pokemonIds, user.teamIds). have to be careful though, since _.difference returns unique values only, so multiple pokemon of same type will not be accounted for)

probably something is out of sync with loading the images and rendering them afterwards. the issue doesn't occur if the image is already cached.

edit: When world calls the initial render, map and player potentially have not loaded yet.

e.g http://img.pokemondb.net/artwork/charmander.jpg

https://github.com/Zarel/honko-damagecalc