eps1lon / poe-mods

Emulates interaction of Mods with Items, Atlas etc. in Path of Exile

I maintain stuff

poe-mods's Issues

Quality not affecting defences and phys damage

Quality is and inc modifier for every defense stat and weapon phys damage

Item refactoring

• merge props and properties
• build Socket component

snapshot test

Since tests are based on data/*.json files and those are just unsorted arrays the snapshots should have a stable order to avoid noise on diffs when the underlying Content.ggpk changes row order which happens quite often in patches.

`Generator.modsFor` typing

GeneratorDetails only contains Flags but should probably list the explicit Flags type. On the other hand the mod should probably not have the actual Mod type since we only have one Mod type.

An in-range update of prettier is breaking the build 🚨

The devDependency prettier was updated from 1.14.2 to 1.14.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

prettier is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).
• ✅ coverage/coveralls: First build on greenkeeper/prettier-1.14.3 at 94.349% (Details).

---

Release Notes for 1.14.3

🔗 Changelog

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Include greenkeeper-lockfile in travis

See eps1lon/poe-i18n#54

Await a greenkeper pr in that repo and check if it worked.

interfaces static properties

flow 0.62 removed support for static properties in interfaces and therfore #13 break.

Version 10 of node.js has been released

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Replaced the old Node.js version in your .nvmrc with the new one

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

More information on this issue

Greenkeeper has checked the engines key in any package.json file, the .nvmrc file, and the .travis.yml file, if present.

• engines was only updated if it defined a single version, not a range.
• .nvmrc was updated to Node.js 10
• .travis.yml was only changed if there was a root-level node_js that didn’t already include Node.js 10, such as node or lts/*. In this case, the new version was appended to the list. We didn’t touch job or matrix configurations because these tend to be quite specific and complex, and it’s difficult to infer what the intentions were.

For many simpler .travis.yml configurations, this PR should suffice as-is, but depending on what you’re doing it may require additional work or may not be applicable at all. We’re also aware that you may have good reasons to not update to Node.js 10, which is why this was sent as an issue and not a pull request. Feel free to delete it without comment, I’m a humble robot and won’t feel rejected 🤖

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

commonJS build breaking

The commonjs build has a malformed meta_data.json. It has a added "use strict" directive.

An in-range update of @types/node is breaking the build 🚨

The devDependency @types/node was updated from 10.11.0 to 10.11.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).
• ✅ coverage/coveralls: First build on greenkeeper/@types/node-10.11.1 at 94.349% (Details).

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Reduce meta_data size

• reduce size
• use json and json import enabled by #72

$ yarn run build
[...]
[BABEL] Note: The code generator has deoptimised the styling of "/home/travis/build/eps1lon/poe-mods/src/util/meta_data.ts" as it exceeds the max of "500KB".
[...]

ItemShowcase#applicableTo broken

Actual Behavior

applicableTo() returns an object that evaluates to true with anySet()

Expected
evaluates to false

npm2yarn

#61 made the switch from npm to yarn. Some scripts however are stil run with npm. Check also travis.

item level requirement

Not affected by stats and no method to determine if it is augmented.

Edit: same for requirments

Aggregate Masterbench

Add a generator that combines all possible masterbenches.

V2

Tracking issue for proposed breaking changes:

• use ItemClassId in prop types in schema.ts introduced in #69
• switch to id only in mod_type
• add generic argument to Generator. It can apply some T to Containers. e.g. MasterBenchoption applies an Option not a Mod.

"Superior" prefix missing on normal items

Update mod domains

Omega_K2 - Today at 8:16 AM
TEM = 1
    FLASK = 2
    MONSTER = 3
    CHEST = 4
    AREA = 5
    UNKNOWN1 = 6
    UNKNOWN2 = 7
    UNKNOWN3 = 8
    CRAFTED = 9
    # Corruptions, item limits, jewel mods, other stuff?
    MISC = 10
    ATLAS = 11
    LEAGUESTONE = 12
    ABYSS_JEWEL = 13
    MAP_DEVICE = 14
    DUMMY = 15

    # legacy names
    MASTER = 9
    JEWEL = 10

Add essence documentation

Add documentation for #43

Affix conflict with implicits

Item: dex_int shield

Suffix spell dodge is marked as already present but it's only present on implicits.

Reintroduce verifySchema

Port to typescriot removed verifySchema.

• look for json schema validator
• auto generate validator from typescript

Public API documentation

#26 introduced a full documentation of the internal API. Find a way to only display members that are reachable from an entry file.

Roll stats

Add support to lock stat values of a Mod to a value (within the rollable range).

Update hapijs / hoek

See https://nvd.nist.gov/vuln/detail/CVE-2018-3728

Todo:

• figure out who includes this
• fix it

Random test coverage

Use of Math.random in certain functions results in varying test coverage.

Mock Math.random in jest tests to guarantee deterministic coverage report.

Update dependencies

• jest to 23.x
• lodash to >=4.17.5 to fix security vulnerability