eps1lon / codemod-missing-await-act

WIP Adds missing await to act calls (or its callers)

I maintain stuff

codemod-missing-await-act's Issues

missed patterns

checkboxes.slice(0, 2).forEach((switchEl) => toggleSwitch(switchEl))
									         ^^^^^^^^^^^^ became async

Curried calls:

const renderMock = (Component) => (props) => render(<Component {...props} />)
// missing `await`
const view = renderMock(() => null)({})

Common manual fixes

Adding an Awaited when using ReturnType<typeof someNewlyAsyncTestingLibraryMethod>

 import { render } from '@testing-library/react';

-let screen: ReturnType<typeof render>;
+let screen: Awaited<ReturnType<typeof render>>;

default import name should be ignored

With a file like

import render from '../render'

render()

and an import config like

import render2 from '../render'

the transform isn't applied but should.

Output new rules to run codemod again

When an exported method changed to async we need to propagate that.

We'll stick to ESM for now for simplicity. However, the module specifier will be unknown so that requires user input.

Once #6 is done we can directly output the recommended config and prompt the user for the source specifier.

Add config for what contains an `act` call

Codebases will have their own wrappers around React Testing Libraries. Once the codemod is applied these wrappers will now also be async which needs to be propagated.

Ideally we could just propagate this through files but that needs a full resolver implementation and building up a fully dependency tree (in memory). It seems better to use an iterative approach to propagating these changes:

rules = ReactTestingLibraryAPIS
while (rules are not empty) 
  apply codemod with rules
  rules = public APIs that just now became `async`

This issue will just add the config option.

Link to LOC when warning about newly async export

e.g.

/Users/sebastian.silbermann/klapp/clients/packages/features/products-and-search/redux-fetch-module/testUtils/index.tsx: Export 'renderWithStore' is now async. Make sure to update the rules of this codemod and run it again.

should link to line and column directly