epicollect / epi-collect Goto Github PK

Currently we unzip the Google Takeout data on the server. This works well, but requires large data uploads and processing power on the server. It'd be better if we can do this on the client.

Description

When navigating back to the map to filter data, there's a minor bug where clicking on a previously drawn polygon causes an attempted state update on an unmounted component.

Steps to reproduce

1. Go to http://localhost:3000/wizard
2. Upload some data (e.g. in tests/data)
3. Draw some polygons on the map
4. Click 'Next'
5. Now go back via the breadcrumbs to 'Review and filter data'.
6. Click the "hand" icon to go into dragging mode.
7. Click on the polygon.
8. Console will throw:

index.js:1 Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in GeoMap (at GeoMap.tsx:23)
    in Unknown (at SelectData.tsx:21)
    in div (at SelectData.tsx:20)
    in SelectData (created by Context.Consumer)
    in Route (at Wizard.tsx:85)

This warning should not appear.

Under GDPR, there may be more services that allow users to download their location data. It'd be good if we can support these to also allow users without Google location history to submit data.

Current state

When a user wants to delete their data using their token on https://epi-collect.org/delete, at the moment as soon as they click submit all their data will be deleted (after it has been verified to be a correct token in the backend).

Desired state

When a user wants to delete their data:

1. They enter their token
2. They see in the UI that this will delete X locations and Y answers to questions they submitted.
3. They can confirm deletion.

Changes required

• In the backend (api.py), the current delete route will need to be split into two: one route that returns the number of data points and one to confirm deletion.
• In the frontend, when submitting, we first call the first route, then show a modal / other UI component to the user stating how many data points there are and allow them to confirm. Then call the second route and delete the data.