ephraimb / capstoneproject Goto Github PK

If you do include mobile styles (using media queries), it is good practice to add the following line to your head when you're using media queries with width delimiters. This will ensure mobile styles will appear.

Adding this inside your HTML gave me your mobile styles.

<meta name="viewport" content="width=device-width, initial-scale=1">

Here's some further reading on this line. Check out the viewport sections.

https://developers.google.com/web/fundamentals/design-and-ui/responsive/

Grade: Meets Expectations

Summary: This project is good! It meets the spec and the code is clean/free of any errors. No major areas of improvement, but read into including viewport in your head to enable mobile styling!

As a challenge, a great exercise would be expanding the site with links to the other pages, making minor style tweaks to these pages (the importance here is just getting to practice building multi-page sites). This will give you experience with building and managing a multi-page website.

Good work!

Overall, you have done a good job on the organization of your HTML & CSS! Indentation is overall solid, classnames are descriptive, and there's no real areas of confusion. Ultimately, the first job is to deliver the output you want, but there's a lot of value to code quality as well!

Nice job!

Indentation seems like a little thing, but early on a lot of new developers struggle with it and can get into bad habits. Your indentation is great. Very consistent and no wasted space. It's a small part of programming, practically non-existent in the minds of senior developers, but to get into good habits like you're setting now is excellent.