englercj / lumber Goto Github PK

Callback needs to be called even if the log level is too low for some transports.

Log rotation works correctly, keeps the right number of files at the right sizes, but the numbers are off:

 my.log
 my.log.2
 my.log.3
 my.log.4
 my.log.5
 my.log.6
 my.log.7
 my.log.8
 my.log.9
 my.log.10
 my.log.11

Seems to skip a number every once in a while, will investigate further when I get a chance.

I was unable to get a new lumber.encoders.Text to honor a 'colorize' setting of false. I believe the code that sets the colorize option is incorrect:

self.colorize = options.colorize || true;

I've instead patched the Text constructor to do this:

function valid_option(value, def) {
    return (typeof value === "undefined") ? def : value;
}

self.colorize = valid_option(options.colorize, true);
self.timestamp = valid_option(options.timestamp, false);
self.headFormat = valid_option(options.headFormat, '%l: ');
self.dateFormat = valid_option(options.dateFormat, 'isoDateTime');

Logging transports should inherit the parent logger's defaults, so defaults can be specified at that level and then will trickle down into the transport's settings.