endjin / cnab.quickstarts Goto Github PK

Hi, I'm one of the creators of Porter. I just saw your video of how the azure quickstarts would work with porter. Looks great! 💯

I noticed that the file structure checked into github is out of date and wanted to help with that. Since people will be learning about porter from the QuickStarts, it would be helpful for us to use the current best practices so that they are on a good path for when they author their own bundles.

Currently you have the following set of files checked in:

porter

• cnab
  • app
    • your files
    • run
    • Dockerfile.base
• porter.yaml

The new file structure looks like this:

porter

• your files
• porter.yaml
• Dockerfile.base

Porter now handles generating the cnab/app directory just-in-time during porter build, along with the run script (it's created at .cnab/app) and should not be checked in.

Your Dockerfile.base would change this line:

COPY cnab/app/manifests/ /cnab/app/manifests/

to this:

COPY manifests $BUNDLE_DIR/manifests

In case it's helpful, here is some new documentation on how the custom dockerfile works.

Let me know how I can help, or if a pull request would be welcome, I can do that too. I'd love to help make the quickstarts a success!