Comments (16)
I think @maelle 's approach in eblondel/ows4R#65 (comment) would be great. There are layers in there with no geometry as they are required or used in the infrastructure of EMODnet-Biology, so we cannot really get rid of them.
In any case I will check why some layers don't have a geometry. For instance Dataportal:eurobis-obisenv_basic. Probably someone just forgot as the important fields when exporting to csv are decimalLongitude and decimalLatitude.
from emodnetwfs.
@salvafern #83 is meant to tackle this.
from emodnetwfs.
@salvafern My main problem in #83 is the size of fixtures. So if you can have a look at the functionality, that'd be great, I can keep thinking about the testing.
from emodnetwfs.
@annakrystalli for a change would you like to try running this one? 😅
from emodnetwfs.
Same error for me in http-tests
branch.
I think it's because the package does some post processing to the crs that fails if the response is not an sf
from emodnetwfs.
the layer type in the layer medata from wfs info was sf, should it indicate something else?
from emodnetwfs.
I see "sf" is hard-coded, maybe I can get it from the web service 👀
from emodnetwfs.
I modified ows4R code
to quiet = FALSE
I get
no simple feature geometries present: returning a data.frame or tbl_df
from emodnetwfs.
I wonder whether we should expect more metadata before the download.
from emodnetwfs.
And when we do get a data.frame, the layers can obviously NOT be reduced.
from emodnetwfs.
So, TODOS
- Find more info on data.frame layers in WFS in general.
- Tweak the code so that we simply return the data.frame when that's what was returned by the web service.
from emodnetwfs.
And when we do get a data.frame, the layers can obviously NOT be reduced.
That's ok because the function only tries to reduce and if it can't it returns a list
from emodnetwfs.
https://geo.vliz.be/geoserver/Dataportal/wfs?SERVICE=WFS&REQUEST=DescribeFeatureType&VERSION=2.0.0 does not have info that it's a table
from emodnetwfs.
Related eblondel/ows4R#65
from emodnetwfs.
For any layer if we get its description and see no element is a geometry, we can know it will be a data.frame rather than an sf object.
from emodnetwfs.
Update: we should not change Dataportal:eurobis-obisenv_basic in geoserver as many other system are relying on this layer. We should go forward with #83 . @maelle are you following this up or shall I have a look?
from emodnetwfs.
Related Issues (20)
- new test failure
- pkgdown failure due to vignette HOT 4
- Get list of all OGC endpoints from catalog instead of hard-coded text file HOT 8
- Link to WFS endpoints in emodnetwfs.Rmd is broken HOT 2
- `emodnet_get_wfs_info(wfs_bio)` introduced twice HOT 1
- Question: Dump all data in one go? HOT 5
- add section about related packages to README HOT 1
- increase test coverage HOT 2
- investigate R CMD check error that pkgcheck is mentioning HOT 3
- All layers are of class data.frame? HOT 3
- explore wfs biology_new_data_products HOT 7
- why would one use rerddap HOT 2
- Could guess_layer_format() use ows4r's `$getGeometryType()`?
- Problem with a layer of the physics server HOT 6
- update example in request-params.Rmd HOT 7
- change lifecycle badge status once build green again
- could we rename the package to all lowercase? HOT 34
- Bug with a layer of biology_occurrence_data HOT 13
- Bug with a layer of chemistry_marine_litter HOT 12
- How to get the package listed from the FAQ
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from emodnetwfs.