Comments (7)
it seems it's not ready? @salvafern it's in the text file you created, but .emodnet_get_wfs_info()
fails on it because there are no layer names?
from emodnetwfs.
this raises an issue: if we read the text file directly from GitHub, and a new service is added, we might inadvertently a "not ready" service to users of the R packages.
should EMODnetWFS contain a list of service names, so we can filter services that we've already tried with the R package? For now I have a "manual" exclusion of "biology_new_data_products" for instance, but instead we might want to exclude any service that's not in a list of known services.
from emodnetwfs.
I overlooked that one :/ I just turned the markdown tables in the README into txt files.
This service in particular it is because we are uploading some of the data products of emodnet biology to the emodnet geoserver instead of the VLIZ one. But only some due to technical constrains. It should work eventually tho. edit: currently we add here only raster data, no vector. See #154 (comment)
should EMODnetWFS contain a list of service names, so we can filter services that we've already tried with the R package?
I agree. Maybe a CI/CD check that tries every new service added to the list - and raises a github issue if it fails?
from emodnetwfs.
I added an internal function curated_services()
with the services we currently "know".
Would there be a simpler way to follow services being added to the fleet, so they can be tested?
And regarding this service in particular, when do you think it will work, and how should we document how it differs from/complements the other biology service?
from emodnetwfs.
I'm looking for a simpler way because I'm not sure we're expecting that many new services? And hopefully the new services are advertised somewhere, maybe a newsletter, mailing list?
from emodnetwfs.
However with curated_services()
we come back to having a hard coded list of services, don't we?
I don't have a good solution tho. Maybe a test that checks new services?
- Either here in EMODnetWFS (but outside of the mocked testing suit following the spirit of https://books.ropensci.org/http-testing/vcr.html#also-testing-for-real-interactions - that you wrote I think 😄 )
- Or in EMODnet/Web-Service-Documentation
Regarding biology_new_data_products
I have news :). In this phase IV we are not adding any vector data to this service, but instead all the products are served as raster via netcdf stores. When we have data products as vector data, we are adding them in the vliz geoserver. This is the current state due to technical reasons. Ideally we would serve all data from only the emodnet geoserver, and hopefully we will get there at some point.
But for now biology_new_data_products
has no purpose for EMODnetWFS since there is no vector data, and no purpose either in the list of web services imo. I raised it here: EMODnet/Web-Service-Documentation@86df44c#r108593181
from emodnetwfs.
However with curated_services() we come back to having a hard coded list of services, don't we?
yes but their URLs are not hard coded. 😅
I still think that instead of having an automated system, the most important thing is ensuring a human looks for new services "once in a while", when preparing a new package release, or when getting notified of a new service in a mailing list. Are new services announced somewhere else than the documentation repo? 🤔
from emodnetwfs.
Related Issues (20)
- new test failure
- pkgdown failure due to vignette HOT 4
- Get list of all OGC endpoints from catalog instead of hard-coded text file HOT 8
- Link to WFS endpoints in emodnetwfs.Rmd is broken HOT 2
- `emodnet_get_wfs_info(wfs_bio)` introduced twice HOT 1
- Question: Dump all data in one go? HOT 5
- add section about related packages to README HOT 1
- increase test coverage HOT 2
- investigate R CMD check error that pkgcheck is mentioning HOT 3
- All layers are of class data.frame? HOT 3
- why would one use rerddap HOT 2
- Could guess_layer_format() use ows4r's `$getGeometryType()`?
- Problem with a layer of the physics server HOT 6
- update example in request-params.Rmd HOT 7
- change lifecycle badge status once build green again
- could we rename the package to all lowercase? HOT 32
- Bug with a layer of biology_occurrence_data HOT 12
- Bug with a layer of chemistry_marine_litter HOT 7
- How to get the package listed from the FAQ
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from emodnetwfs.